kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3295) Unused method SQLDigestUtil#appendTsFilterToExecute
Date Tue, 29 May 2018 04:48:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493099#comment-16493099
] 

ASF GitHub Bot commented on KYLIN-3295:
---------------------------------------

codecov-io commented on issue #145: KYLIN-3295, clean unused class:SQLDigestUtil
URL: https://github.com/apache/kylin/pull/145#issuecomment-392651611
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/145?src=pr&el=h1) Report
   > Merging [#145](https://codecov.io/gh/apache/kylin/pull/145?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/4c67905d3cd82a0330a5ff212bd53187636623d0?src=pr&el=desc)
will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/145/graphs/tree.svg?token=JawVgbgsVo&src=pr&height=150&width=650)](https://codecov.io/gh/apache/kylin/pull/145?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #145      +/-   ##
   ============================================
   + Coverage     21.85%   21.87%   +0.02%     
   + Complexity     3889     3888       -1     
   ============================================
     Files           985      984       -1     
     Lines         59716    59660      -56     
     Branches       8623     8608      -15     
   ============================================
     Hits          13052    13052              
   + Misses        45452    45395      -57     
   - Partials       1212     1213       +1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/145?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/145/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
| `70.94% <0%> (-1.36%)` | `8% <0%> (ø)` | |
   | [...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/145/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/145/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/145?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/145?src=pr&el=footer).
Last update [4c67905...4e2000a](https://codecov.io/gh/apache/kylin/pull/145?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Unused method SQLDigestUtil#appendTsFilterToExecute
> ---------------------------------------------------
>
>                 Key: KYLIN-3295
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3295
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Minor
>             Fix For: v2.4.0
>
>
> SQLDigestUtil#appendTsFilterToExecute is not called anywhere.
> {code}
>        T ret = action.apply(null);
> {code}
> Passing null to {{apply}} seems incorrect.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message