kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shaofeng SHI (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3071) Add config to reuse dict to reduce dict size
Date Sun, 06 May 2018 13:04:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465113#comment-16465113
] 

Shaofeng SHI commented on KYLIN-3071:
-------------------------------------

I think we can enable it by default, this is more useful than growing dict.

 

[~liyang.gmt8@gmail.com] any concern on it?

> Add config to reuse dict to reduce dict size 
> ---------------------------------------------
>
>                 Key: KYLIN-3071
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3071
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Metadata
>            Reporter: Yang Hao
>            Assignee: Yang Hao
>            Priority: Major
>             Fix For: Future
>
>         Attachments: KYLIN-3071.apache-master.001.patch
>
>
> When calling DictionaryManager.trySaveNewDict, and growing dict is not enabled, it only
use the history dict which is equal, it may generate many dict. We should supply a config
to use contains instead of equal to reuse old dict.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message