From issues-return-16927-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Mon Mar 19 04:15:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9A1E4180645 for ; Mon, 19 Mar 2018 04:15:08 +0100 (CET) Received: (qmail 78517 invoked by uid 500); 19 Mar 2018 03:15:07 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 78508 invoked by uid 99); 19 Mar 2018 03:15:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2018 03:15:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0BC0A1804BC for ; Mon, 19 Mar 2018 03:15:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id N3UzfC7_Q8Fp for ; Mon, 19 Mar 2018 03:15:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C99565F5FB for ; Mon, 19 Mar 2018 03:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 146FDE0181 for ; Mon, 19 Mar 2018 03:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B424D2128A for ; Mon, 19 Mar 2018 03:15:00 +0000 (UTC) Date: Mon, 19 Mar 2018 03:15:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3257) Useless call in FuzzyValueCombination MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404333#comment-16404333 ] ASF GitHub Bot commented on KYLIN-3257: --------------------------------------- lidongsjtu closed pull request #120: KYLIN-3257 remove useless call in FuzzyValueCombination URL: https://github.com/apache/kylin/pull/120 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/core-cube/src/main/java/org/apache/kylin/cube/common/FuzzyValueCombination.java b/core-cube/src/main/java/org/apache/kylin/cube/common/FuzzyValueCombination.java index 74012a4e62..1be3cccd81 100644 --- a/core-cube/src/main/java/org/apache/kylin/cube/common/FuzzyValueCombination.java +++ b/core-cube/src/main/java/org/apache/kylin/cube/common/FuzzyValueCombination.java @@ -44,7 +44,6 @@ } public static List> calculate(Map> fuzzyValues, long cap) { - Collections.emptyMap(); Dim[] dims = toDims(fuzzyValues); // If a query has many IN clause and each IN clause has many values, then it will easily generate // thousands of fuzzy keys. When there are lots of fuzzy keys, the scan performance is bottle necked diff --git a/core-storage/src/main/java/org/apache/kylin/storage/translate/FuzzyValueCombination.java b/core-storage/src/main/java/org/apache/kylin/storage/translate/FuzzyValueCombination.java index bfa398ed4a..c6fa4b4531 100644 --- a/core-storage/src/main/java/org/apache/kylin/storage/translate/FuzzyValueCombination.java +++ b/core-storage/src/main/java/org/apache/kylin/storage/translate/FuzzyValueCombination.java @@ -46,7 +46,6 @@ } public static List> calculate(Map> fuzzyValues, long cap) { - Collections.emptyMap(); Dim[] dims = toDims(fuzzyValues); // If a query has many IN clause and each IN clause has many values, then it will easily generate // thousands of fuzzy keys. When there are lots of fuzzy keys, the scan performance is bottle necked ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Useless call in FuzzyValueCombination > ------------------------------------- > > Key: KYLIN-3257 > URL: https://issues.apache.org/jira/browse/KYLIN-3257 > Project: Kylin > Issue Type: Bug > Reporter: Ted Yu > Assignee: Wenzheng Liu > Priority: Minor > > {code} > public static List> calculate(Map> fuzzyValues, long cap) { > Collections.emptyMap(); > {code} > The empty map has no effect to method execution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)