kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3293) FixedLenHexDimEnc return a wrong code length leads to cut bytes error.
Date Fri, 16 Mar 2018 14:47:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401993#comment-16401993
] 

ASF GitHub Bot commented on KYLIN-3293:
---------------------------------------

coveralls commented on issue #117: KYLIN-3293, fix FixedLenHexDimEnc.java return a wrong code
length lea…
URL: https://github.com/apache/kylin/pull/117#issuecomment-373735894
 
 
   ## Pull Request Test Coverage Report for [Build 3049](https://coveralls.io/builds/16016963)
   
   * **6** of **9**  **(66.67%)** changed or added relevant lines in **1** file are covered.
   * **15** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.005%**) to **23.895%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-metadata/src/main/java/org/apache/kylin/dimension/FixedLenHexDimEnc.java](https://coveralls.io/builds/16016963/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdimension%2FFixedLenHexDimEnc.java#L253)
| 6 | 9 | 66.67%
   <!-- | **Total:** | **6** | **9** | **66.67%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/16016963/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
| 5 | 77.81% |
   | [storage-hbase/src/main/java/org/apache/kylin/storage/hbase/HBaseConnection.java](https://coveralls.io/builds/16016963/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2FHBaseConnection.java#L81)
| 10 | 17.28% |
   <!-- | **Total:** | **15** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/16016963/badge)](https://coveralls.io/builds/16016963)
|
   | :-- | --: |
   | Change from base [Build 3046](https://coveralls.io/builds/15980899): |  0.005% |
   | Covered Lines: | 14337 |
   | Relevant Lines: | 59999 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> FixedLenHexDimEnc return a wrong code length leads to cut bytes error.
> ----------------------------------------------------------------------
>
>                 Key: KYLIN-3293
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3293
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: jiatao.tao
>            Assignee: jiatao.tao
>            Priority: Major
>
> FixedLenHexDimEnc lost its byteLen when deserializing, so in  GTRecord#loadColumnsFromColumnBlocks,
the byte after cutting are wrong.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message