kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3280) The delete button should not be enabled without any segment in cube segment delete confirm dialog
Date Fri, 09 Mar 2018 02:52:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392314#comment-16392314
] 

ASF GitHub Bot commented on KYLIN-3280:
---------------------------------------

codecov-io commented on issue #113: KYLIN-3280
URL: https://github.com/apache/kylin/pull/113#issuecomment-371697041
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=h1) Report
   > Merging [#113](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/56e73333dc6f4b7e074826070c806209d0bdab79?src=pr&el=desc)
will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/113/graphs/tree.svg?src=pr&token=JawVgbgsVo&width=650&height=150)](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #113      +/-   ##
   ============================================
   + Coverage     21.55%   21.58%   +0.02%     
   - Complexity     3850     3854       +4     
   ============================================
     Files           996      996              
     Lines         59964    59964              
     Branches       8661     8661              
   ============================================
   + Hits          12924    12941      +17     
   + Misses        45843    45826      -17     
     Partials       1197     1197
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `70.21% <0%> (+0.91%)` | `7% <0%> (ø)` | :arrow_down: |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `16.18% <0%> (+1.22%)` | `37% <0%> (+2%)` | :arrow_up: |
   | [...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
| `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: |
   | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh)
| `32.35% <0%> (+1.68%)` | `21% <0%> (+1%)` | :arrow_up: |
   | [...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==)
| `100% <0%> (+100%)` | `1% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=footer).
Last update [56e7333...e4819c9](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The delete button should not be enabled without any segment in cube segment delete confirm
dialog
> -------------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-3280
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3280
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.4.0
>            Reporter: Peng Xing
>            Assignee: Peng Xing
>            Priority: Minor
>         Attachments: delete_segment.png
>
>
> 1. Open cube list, choose one disabled cube, then select 'Delete Segment';
> 2. The Delete button is enabled without any segment, and if you click it, it has no prompt.
> please see the attachment picture.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message