kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3257) Useless call in FuzzyValueCombination
Date Mon, 19 Mar 2018 03:15:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404333#comment-16404333
] 

ASF GitHub Bot commented on KYLIN-3257:
---------------------------------------

lidongsjtu closed pull request #120: KYLIN-3257 remove useless call in FuzzyValueCombination
URL: https://github.com/apache/kylin/pull/120
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core-cube/src/main/java/org/apache/kylin/cube/common/FuzzyValueCombination.java
b/core-cube/src/main/java/org/apache/kylin/cube/common/FuzzyValueCombination.java
index 74012a4e62..1be3cccd81 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/common/FuzzyValueCombination.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/common/FuzzyValueCombination.java
@@ -44,7 +44,6 @@
     }
 
     public static <K, V> List<Map<K, V>> calculate(Map<K, Set<V>>
fuzzyValues, long cap) {
-        Collections.emptyMap();
         Dim<K, V>[] dims = toDims(fuzzyValues);
         // If a query has many IN clause and each IN clause has many values, then it will
easily generate 
         // thousands of fuzzy keys. When there are lots of fuzzy keys, the scan performance
is bottle necked 
diff --git a/core-storage/src/main/java/org/apache/kylin/storage/translate/FuzzyValueCombination.java
b/core-storage/src/main/java/org/apache/kylin/storage/translate/FuzzyValueCombination.java
index bfa398ed4a..c6fa4b4531 100644
--- a/core-storage/src/main/java/org/apache/kylin/storage/translate/FuzzyValueCombination.java
+++ b/core-storage/src/main/java/org/apache/kylin/storage/translate/FuzzyValueCombination.java
@@ -46,7 +46,6 @@
     }
 
     public static <E> List<Map<TblColRef, E>> calculate(Map<TblColRef,
Set<E>> fuzzyValues, long cap) {
-        Collections.emptyMap();
         Dim[] dims = toDims(fuzzyValues);
         // If a query has many IN clause and each IN clause has many values, then it will
easily generate 
         // thousands of fuzzy keys. When there are lots of fuzzy keys, the scan performance
is bottle necked 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Useless call in FuzzyValueCombination
> -------------------------------------
>
>                 Key: KYLIN-3257
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3257
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Wenzheng Liu
>            Priority: Minor
>
> {code}
>     public static <K, V> List<Map<K, V>> calculate(Map<K, Set<V>>
fuzzyValues, long cap) {
>         Collections.emptyMap();
> {code}
> The empty map has no effect to method execution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message