kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3257) Useless call in FuzzyValueCombination
Date Mon, 19 Mar 2018 03:11:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404330#comment-16404330
] 

ASF GitHub Bot commented on KYLIN-3257:
---------------------------------------

codecov-io commented on issue #120: KYLIN-3257 remove useless call in FuzzyValueCombination
URL: https://github.com/apache/kylin/pull/120#issuecomment-374088896
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/120?src=pr&el=h1) Report
   > Merging [#120](https://codecov.io/gh/apache/kylin/pull/120?src=pr&el=desc) into
[master](https://codecov.io/gh/apache/kylin/commit/4bcd8a14d3fcce385057275fcae10520abe2ead2?src=pr&el=desc)
will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/120/graphs/tree.svg?height=150&token=JawVgbgsVo&width=650&src=pr)](https://codecov.io/gh/apache/kylin/pull/120?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #120      +/-   ##
   ============================================
   - Coverage     21.83%   21.81%   -0.03%     
   + Complexity     3888     3884       -4     
   ============================================
     Files           999      999              
     Lines         60064    60062       -2     
     Branches       8673     8673              
   ============================================
   - Hits          13117    13102      -15     
   - Misses        45727    45741      +14     
   + Partials       1220     1219       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/120?src=pr&el=tree) | Coverage
Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/kylin/cube/common/FuzzyValueCombination.java](https://codecov.io/gh/apache/kylin/pull/120/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2NvbW1vbi9GdXp6eVZhbHVlQ29tYmluYXRpb24uamF2YQ==)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...kylin/storage/translate/FuzzyValueCombination.java](https://codecov.io/gh/apache/kylin/pull/120/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL3RyYW5zbGF0ZS9GdXp6eVZhbHVlQ29tYmluYXRpb24uamF2YQ==)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/120/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==)
| `0% <0%> (-100%)` | `0% <0%> (-1%)` | |
   | [...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/120/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh)
| `30.67% <0%> (-1.69%)` | `20% <0%> (-1%)` | |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/120/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `14.89% <0%> (-1.23%)` | `35% <0%> (-2%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/120/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/120?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/120?src=pr&el=footer).
Last update [4bcd8a1...f743946](https://codecov.io/gh/apache/kylin/pull/120?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Useless call in FuzzyValueCombination
> -------------------------------------
>
>                 Key: KYLIN-3257
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3257
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Wenzheng Liu
>            Priority: Minor
>
> {code}
>     public static <K, V> List<Map<K, V>> calculate(Map<K, Set<V>>
fuzzyValues, long cap) {
>         Collections.emptyMap();
> {code}
> The empty map has no effect to method execution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message