kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-2884) Add delete segment function for portal
Date Sat, 24 Feb 2018 08:43:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-2884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375414#comment-16375414
] 

ASF GitHub Bot commented on KYLIN-2884:
---------------------------------------

chenzhx closed pull request #105: KYLIN-2884 Add delete segment function for portal - bug
fix
URL: https://github.com/apache/kylin/pull/105
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/webapp/app/js/controllers/cubes.js b/webapp/app/js/controllers/cubes.js
index a38620218b..cbd6fad1bb 100644
--- a/webapp/app/js/controllers/cubes.js
+++ b/webapp/app/js/controllers/cubes.js
@@ -522,23 +522,25 @@ KylinApp.controller('CubesCtrl', function ($scope, $q, $routeParams,
$location,
       })
     };
 
-    $scope.startDeleteSegment = function (cube) {
-          $scope.metaModel={
-            model:modelsManager.getModelByCube(cube.name)
-          };
-          $modal.open({
-            templateUrl: 'deleteSegment.html',
-            controller: deleteSegmentCtrl,
-            resolve: {
-              cube: function () {
-                return cube;
-              },
-              scope: function() {
-                return $scope;
-              }
-            }
-          });
-        };
+     $scope.startDeleteSegment = function (cube) {
+       $scope.loadDetail(cube).then(function () {
+         $scope.metaModel={
+           model:modelsManager.getModelByCube(cube.name)
+         };
+         $modal.open({
+           templateUrl: 'deleteSegment.html',
+           controller: deleteSegmentCtrl,
+           resolve: {
+             cube: function () {
+               return cube;
+             },
+             scope: function() {
+               return $scope;
+             }
+           }
+         });
+       });
+     };
 
   });
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add delete segment function for portal
> --------------------------------------
>
>                 Key: KYLIN-2884
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2884
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Web 
>            Reporter: Pan, Julian
>            Assignee: Pan, Julian
>            Priority: Major
>             Fix For: Future
>
>         Attachments: KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch, KYLIN-2884.patch,
KYLIN-2884.patch, screenshot-1.png, screenshot-2.png
>
>
> Kylin restful already support delete segment function. Could we add a action button for
front-end to user?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message