Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B41F6160C26 for ; Wed, 3 Jan 2018 06:40:04 +0100 (CET) Received: (qmail 17469 invoked by uid 500); 3 Jan 2018 05:40:03 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 17456 invoked by uid 99); 3 Jan 2018 05:40:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jan 2018 05:40:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 18E571805BE for ; Wed, 3 Jan 2018 05:40:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.011 X-Spam-Level: X-Spam-Status: No, score=-108.011 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id KyVZUQDV1zM0 for ; Wed, 3 Jan 2018 05:40:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BF9395F3E1 for ; Wed, 3 Jan 2018 05:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C46E2E0EFA for ; Wed, 3 Jan 2018 05:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 757AA240EE for ; Wed, 3 Jan 2018 05:40:00 +0000 (UTC) Date: Wed, 3 Jan 2018 05:40:00 +0000 (UTC) From: "Shaofeng SHI (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (KYLIN-3081) Ineffective null check in CubeController#cuboidsExport MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 03 Jan 2018 05:40:05 -0000 [ https://issues.apache.org/jira/browse/KYLIN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaofeng SHI resolved KYLIN-3081. --------------------------------- Resolution: Fixed > Ineffective null check in CubeController#cuboidsExport > ------------------------------------------------------ > > Key: KYLIN-3081 > URL: https://issues.apache.org/jira/browse/KYLIN-3081 > Project: Kylin > Issue Type: Bug > Components: Metadata > Reporter: Ted Yu > Assignee: Kaige Liu > Priority: Minor > Fix For: v2.3.0 > > Attachments: KYLIN-3081-fix-potential-npe-02.patch > > > {code} > if (cuboidList == null || cuboidList.isEmpty()) { > logger.warn("Cannot get recommend cuboid list for cube " + cubeName); > } > if (cuboidList.size() < top) { > logger.info("Only recommend " + cuboidList.size() + " cuboids less than topn " + top); > } > {code} > cuboidList.size() may result in NPE because the null check above doesn't have effect. -- This message was sent by Atlassian JIRA (v6.4.14#64029)