From issues-return-15586-archive-asf-public=cust-asf.ponee.io@kylin.apache.org Thu Jan 25 06:56:04 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C0343180676 for ; Thu, 25 Jan 2018 06:56:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B0475160C3C; Thu, 25 Jan 2018 05:56:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0282E160C4E for ; Thu, 25 Jan 2018 06:56:03 +0100 (CET) Received: (qmail 51001 invoked by uid 500); 25 Jan 2018 05:56:03 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 50938 invoked by uid 99); 25 Jan 2018 05:56:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jan 2018 05:56:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9C165C4058 for ; Thu, 25 Jan 2018 05:56:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -107.911 X-Spam-Level: X-Spam-Status: No, score=-107.911 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id E2MQfs-VoO0v for ; Thu, 25 Jan 2018 05:56:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C0CAC5FAF7 for ; Thu, 25 Jan 2018 05:56:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 071B9E0F6E for ; Thu, 25 Jan 2018 05:56:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 513D5240FE for ; Thu, 25 Jan 2018 05:56:00 +0000 (UTC) Date: Thu, 25 Jan 2018 05:56:00 +0000 (UTC) From: "peng.jianhua (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KYLIN-3069) Add proper time zone support to the WebUI instead of GMT/PST kludge MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KYLIN-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338766#comment-16338766 ] peng.jianhua commented on KYLIN-3069: ------------------------------------- Hi, [~Zhixiong Chen] & [~Billy Liu], ok. I updated the patch according to your advise. Thanks. > Add proper time zone support to the WebUI instead of GMT/PST kludge > ------------------------------------------------------------------- > > Key: KYLIN-3069 > URL: https://issues.apache.org/jira/browse/KYLIN-3069 > Project: Kylin > Issue Type: Bug > Components: Web > Affects Versions: v2.2.0 > Environment: HDP 2.5.3, Kylin 2.2.0 > Reporter: Vsevolod Ostapenko > Assignee: peng.jianhua > Priority: Minor > Fix For: v2.3.0 > > Attachments: 0001-KYLIN-3069-Add-proper-time-zone-support-to-the-WebUI.patch, Screen Shot 2017-12-05 at 10.01.39 PM.png, kylin_pic1.png, kylin_pic2.png, kylin_pic3.png > > Original Estimate: 168h > Remaining Estimate: 168h > > Time zone handling logic in the WebUI is a kludge, coded to parse only "GMT-N" time zone specifications and defaulting to PST, if parsing is not successful (kylin/webapp/app/js/filters/filter.js) > Integrating moment and moment time zone (http://momentjs.com/timezone/docs/) into the product, would allow correct time zone handling. > For the users who happen to reside in the geographical locations that do observe day light savings time, usage of GMT-N format is very inconvenient and info reported by the UI in various places is perplexing. > Needless to say that the GMT moniker itself is long deprecated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)