kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From " Kaige Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KYLIN-3081) Ineffective null check in CubeController#cuboidsExport
Date Thu, 04 Jan 2018 02:35:00 GMT

     [ https://issues.apache.org/jira/browse/KYLIN-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kaige Liu updated KYLIN-3081:
-----------------------------
    Attachment: KYLIN-3081-format-code.patch

Fixed code style issue. [~Shaofengshi] please review. Thanks.

> Ineffective null check in CubeController#cuboidsExport
> ------------------------------------------------------
>
>                 Key: KYLIN-3081
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3081
>             Project: Kylin
>          Issue Type: Bug
>          Components: Metadata
>            Reporter: Ted Yu
>            Assignee:  Kaige Liu
>            Priority: Minor
>             Fix For: v2.3.0
>
>         Attachments: KYLIN-3081-fix-potential-npe-02.patch, KYLIN-3081-format-code.patch
>
>
> {code}
>         if (cuboidList == null || cuboidList.isEmpty()) {
>             logger.warn("Cannot get recommend cuboid list for cube " + cubeName);
>         }
>         if (cuboidList.size() < top) {
>             logger.info("Only recommend " + cuboidList.size() + " cuboids less than topn
" + top);
>         }
> {code}
> cuboidList.size() may result in NPE because the null check above doesn't have effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message