Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kylin.apache.org
Date: Wed, 20 Dec 2017 08:43:00 +0000 (UTC)
From: "peng.jianhua (JIRA)" <jira@apache.org>
To: issues@kylin.apache.org
Message-ID: <JIRA.13126200.1513756809000.500719.1513759380046@Atlassian.JIRA>
In-Reply-To: <JIRA.13126200.1513756809000@Atlassian.JIRA>
References: <JIRA.13126200.1513756809000@Atlassian.JIRA> <JIRA.13126200.1513756809603@jira-lw-us.apache.org>
Subject: [jira] [Updated] (KYLIN-3119) A few bugs in the function
 'massageSql' of 'QueryUtil.java'
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 20 Dec 2017 08:43:04 -0000


     [ https://issues.apache.org/jira/browse/KYLIN-3119?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

peng.jianhua updated KYLIN-3119:
--------------------------------
    Description:=20
in the function 'massageSql' of 'QueryUtil.java',there are a few bugs:
01:
{code:java}
        while (sql.endsWith(";"))
            sql =3D sql.substring(0, sql.length() - 1);
{code}
if the sql end with ';' and after the ';' still has comments,will be error.=
Because the sql will add ("\nLIMIT " + limit) at the end.

02:
{code:java}
        if (limit > 0 && !sql.toLowerCase().contains("limit")) {
            sql +=3D ("\nLIMIT " + limit);
        }

        if (offset > 0 && !sql.toLowerCase().contains("offset")) {
            sql +=3D ("\nOFFSET " + offset);
        }
{code}

if the sql already has word 'limit' in it,such as Alias,Subquery,Comments,t=
he =E2=80=98limit=E2=80=99 in the Input box will be invalid.
for example,the sql has subquery,and there is 'limit' in subquery.

{code:java}
select KYLIN_SALES.PART_DT, count(KYLIN_SALES.PRICE)
from KYLIN_SALES
inner join (select ACCOUNT_ID, ACCOUNT_BUYER_LEVEL from KYLIN_ACCOUNT where=
 ACCOUNT_COUNTRY =3D 'US' limit 10000) as TT
on KYLIN_SALES.BUYER_ID =3D TT.ACCOUNT_ID
group by KYLIN_SALES.PART_DT
{code}
the =E2=80=98limit=E2=80=99 in the Input box will be invalid.please refer t=
o 01.png and 02.png.
03:
{code:java}
        // https://issues.apache.org/jira/browse/KYLIN-2649
        if (kylinConfig.getForceLimit() > 0 && !sql.toLowerCase().contains(=
"limit")
                && sql.toLowerCase().contains("*")) {
            sql +=3D ("\nLIMIT " + kylinConfig.getForceLimit());
        }
{code}
Because KYLIN-2649 is still unresolved,so I didn't change the code,but  it =
has same 'limit' word bugs like above.
And there are some situations that the sql contains \*,such as {code:java}c=
ount(*),kylin_sales.*{code}
it seems improperly to deal with the sql just use {code:java}
sql.toLowerCase().contains("*")
{code}
it seems improperly to deal with the sql just use {code:java}
sql.toLowerCase().contains("*")
{code}

  was:
in the function 'massageSql' of 'QueryUtil.java',there are a few bugs:
01:
{code:java}
        while (sql.endsWith(";"))
            sql =3D sql.substring(0, sql.length() - 1);
{code}
if the sql end with ';' and after the ';' still has comments,will be error.=
Because the sql will add ("\nLIMIT " + limit) at the end.

02:
{code:java}
        if (limit > 0 && !sql.toLowerCase().contains("limit")) {
            sql +=3D ("\nLIMIT " + limit);
        }

        if (offset > 0 && !sql.toLowerCase().contains("offset")) {
            sql +=3D ("\nOFFSET " + offset);
        }
{code}

if the sql already has word 'limit' in it,such as Alias,Subquery,Comments,t=
he =E2=80=98limit=E2=80=99 in the Input box will be invalid.
for example,the sql has subquery,and there is 'limit' in subquery.

{code:java}
select KYLIN_SALES.PART_DT, count(KYLIN_SALES.PRICE)
from KYLIN_SALES
inner join (select ACCOUNT_ID, ACCOUNT_BUYER_LEVEL from KYLIN_ACCOUNT where=
 ACCOUNT_COUNTRY =3D 'US' limit 10000) as TT
on KYLIN_SALES.BUYER_ID =3D TT.ACCOUNT_ID
group by KYLIN_SALES.PART_DT
{code}
the =E2=80=98limit=E2=80=99 in the Input box will be invalid.please refer t=
o 01.png and 02.png.
03:
{code:java}
        // https://issues.apache.org/jira/browse/KYLIN-2649
        if (kylinConfig.getForceLimit() > 0 && !sql.toLowerCase().contains(=
"limit")
                && sql.toLowerCase().contains("*")) {
            sql +=3D ("\nLIMIT " + kylinConfig.getForceLimit());
        }
{code}
Because KYLIN-2649 is still unresolved,so I didn't change the code,but  it =
has same 'limit' word bugs like above.
And there are some situations that the sql contains \*,such as {code:java}c=
ount(*),kylin_sales.*{code}
it seems improperly to deal with the sql just use {code:java}
sql.toLowerCase().contains("*")
{code}


> A few bugs in the function 'massageSql' of 'QueryUtil.java'
> -----------------------------------------------------------
>
>                 Key: KYLIN-3119
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3119
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: peng.jianhua
>            Assignee: peng.jianhua
>
> in the function 'massageSql' of 'QueryUtil.java',there are a few bugs:
> 01:
> {code:java}
>         while (sql.endsWith(";"))
>             sql =3D sql.substring(0, sql.length() - 1);
> {code}
> if the sql end with ';' and after the ';' still has comments,will be erro=
r.Because the sql will add ("\nLIMIT " + limit) at the end.
> 02:
> {code:java}
>         if (limit > 0 && !sql.toLowerCase().contains("limit")) {
>             sql +=3D ("\nLIMIT " + limit);
>         }
>         if (offset > 0 && !sql.toLowerCase().contains("offset")) {
>             sql +=3D ("\nOFFSET " + offset);
>         }
> {code}
> if the sql already has word 'limit' in it,such as Alias,Subquery,Comments=
,the =E2=80=98limit=E2=80=99 in the Input box will be invalid.
> for example,the sql has subquery,and there is 'limit' in subquery.
> {code:java}
> select KYLIN_SALES.PART_DT, count(KYLIN_SALES.PRICE)
> from KYLIN_SALES
> inner join (select ACCOUNT_ID, ACCOUNT_BUYER_LEVEL from KYLIN_ACCOUNT whe=
re ACCOUNT_COUNTRY =3D 'US' limit 10000) as TT
> on KYLIN_SALES.BUYER_ID =3D TT.ACCOUNT_ID
> group by KYLIN_SALES.PART_DT
> {code}
> the =E2=80=98limit=E2=80=99 in the Input box will be invalid.please refer=
 to 01.png and 02.png.
> 03:
> {code:java}
>         // https://issues.apache.org/jira/browse/KYLIN-2649
>         if (kylinConfig.getForceLimit() > 0 && !sql.toLowerCase().contain=
s("limit")
>                 && sql.toLowerCase().contains("*")) {
>             sql +=3D ("\nLIMIT " + kylinConfig.getForceLimit());
>         }
> {code}
> Because KYLIN-2649 is still unresolved,so I didn't change the code,but  i=
t has same 'limit' word bugs like above.
> And there are some situations that the sql contains \*,such as {code:java=
}count(*),kylin_sales.*{code}
> it seems improperly to deal with the sql just use {code:java}
> sql.toLowerCase().contains("*")
> {code}
> it seems improperly to deal with the sql just use {code:java}
> sql.toLowerCase().contains("*")
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)