Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@kylin.apache.org
Date: Fri, 8 Dec 2017 14:03:00 +0000 (UTC)
From: "kangkaisen (JIRA)" <jira@apache.org>
To: issues@kylin.apache.org
Message-ID: <JIRA.13123166.1512558913000.417924.1512741780059@Atlassian.JIRA>
In-Reply-To: <JIRA.13123166.1512558913000@Atlassian.JIRA>
References: <JIRA.13123166.1512558913000@Atlassian.JIRA> <JIRA.13123166.1512558913284@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KYLIN-3087) DistributedLock in
 GlobalDictionaryBuilder may not release
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 08 Dec 2017 14:03:04 -0000


    [ https://issues.apache.org/jira/browse/KYLIN-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283535#comment-16283535 ] 

kangkaisen commented on KYLIN-3087:
-----------------------------------

Hi Fangyuan, Thanks you. This patch looks good to me, But doesn't have your author info.  Please re-submit a new patch with your author info by following the guide here:  https://kylin.apache.org/development/howto_contribute.html.  I will merge your patch to master branch, Thanks you.


> DistributedLock in GlobalDictionaryBuilder may not release
> ----------------------------------------------------------
>
>                 Key: KYLIN-3087
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3087
>             Project: Kylin
>          Issue Type: Bug
>          Components: Job Engine
>    Affects Versions: v2.2.0
>            Reporter: Fangyuan Deng
>            Assignee: Fangyuan Deng
>         Attachments: KYLIN-3087.patch
>
>
> In GlobalDictionaryBuilder.init(),
> this.builder = new AppendTrieDictionaryBuilder(baseDir, maxEntriesPerSlice, true);
> if this line has exception, the DistributedLock will not release, and other jobs can not run.
> so,I added a try catch.
>         try {
>             this.builder = new AppendTrieDictionaryBuilder(baseDir, maxEntriesPerSlice, true);
>         } catch (Throwable e) {
>             lock.unlock(getLockPath(sourceColumn));
>             throw new RuntimeException(String.format("Failed to create global dictionary on %s ", sourceColumn), e);
>         }


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)