Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9D61F200D51 for ; Fri, 8 Dec 2017 03:20:43 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 988AB160C1E; Fri, 8 Dec 2017 02:20:43 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DEC40160C0C for ; Fri, 8 Dec 2017 03:20:42 +0100 (CET) Received: (qmail 33993 invoked by uid 500); 8 Dec 2017 02:20:42 -0000 Mailing-List: contact issues-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list issues@kylin.apache.org Received: (qmail 33984 invoked by uid 99); 8 Dec 2017 02:20:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Dec 2017 02:20:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AC849180160 for ; Fri, 8 Dec 2017 02:20:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ET0TauaLLo58 for ; Fri, 8 Dec 2017 02:20:41 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 663C762852 for ; Fri, 8 Dec 2017 02:02:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 24A17E0237 for ; Fri, 8 Dec 2017 02:02:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0DAC921E75 for ; Fri, 8 Dec 2017 02:02:00 +0000 (UTC) Date: Fri, 8 Dec 2017 02:02:00 +0000 (UTC) From: "Pan, Julian (JIRA)" To: issues@kylin.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (KYLIN-3004) Delete cube segment validation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 08 Dec 2017 02:20:43 -0000 [ https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pan, Julian reassigned KYLIN-3004: ---------------------------------- Assignee: Pan, Julian (was: Zhong,Jason) > Delete cube segment validation > ------------------------------ > > Key: KYLIN-3004 > URL: https://issues.apache.org/jira/browse/KYLIN-3004 > Project: Kylin > Issue Type: Bug > Components: REST Service > Affects Versions: v2.1.0 > Reporter: Pan, Julian > Assignee: Pan, Julian > > In version 2.1, kylin allow hole between segment. > But currently, there is validation for delete segment. > Here is the code in CubeService: > if (!segmentName.equals(cube.getSegments().get(0).getName()) > && !segmentName.equals(cube.getSegments().get(cube.getSegments().size() - 1).getName())) { > throw new BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(), segmentName)); > } > Does it make sense? Should we remove the limit? -- This message was sent by Atlassian JIRA (v6.4.14#64029)