kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vsevolod Ostapenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3069) Add proper time zone support to the WebUI instead of GMT/PST kludge
Date Fri, 15 Dec 2017 22:20:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293357#comment-16293357
] 

Vsevolod Ostapenko commented on KYLIN-3069:
-------------------------------------------

[~peng.jianhua], I believe that instead of using
time = moment(item).tz(timezone).format(format) + " (" + timezone + ")";

it should be 
time = moment(item).tz(timezone).format(format + " z");

or formats should include short time zone name element, e.g.
format = "YYYY-MM-DD HH:mm:ss  z";

> Add proper time zone support to the WebUI instead of GMT/PST kludge
> -------------------------------------------------------------------
>
>                 Key: KYLIN-3069
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3069
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.2.0
>         Environment: HDP 2.5.3, Kylin 2.2.0
>            Reporter: Vsevolod Ostapenko
>            Assignee: peng.jianhua
>            Priority: Minor
>         Attachments: 0001-KYLIN-3069-Add-proper-time-zone-support-to-the-WebUI.patch,
Screen Shot 2017-12-05 at 10.01.39 PM.png, kylin_pic1.png, kylin_pic2.png, kylin_pic3.png
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Time zone handling logic in the WebUI is a kludge, coded to parse only "GMT-N" time zone
specifications and defaulting to PST, if parsing is not successful (kylin/webapp/app/js/filters/filter.js)
> Integrating moment and moment time zone (http://momentjs.com/timezone/docs/) into the
product, would allow correct time zone handling.
> For the users who happen to reside in the geographical locations that do observe day
light savings time, usage of GMT-N format is very inconvenient and info reported by the UI
in various places is perplexing.
> Needless to say that the GMT moniker itself is long deprecated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message