kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vsevolod Ostapenko (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KYLIN-3069) Add proper time zone support to the WebUI instead of GMT/PST kludge
Date Wed, 06 Dec 2017 04:36:01 GMT

     [ https://issues.apache.org/jira/browse/KYLIN-3069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vsevolod Ostapenko updated KYLIN-3069:
--------------------------------------
    Attachment: Screen Shot 2017-12-05 at 10.01.39 PM.png

Hi [~peng.jianhua], here is my use case.
I have kylin.web.timezone set to America/New_York in my kylie.properties.
The time zone is a perfectly valid canonical time zone name. JVM has no issues recognizing
it as such. As the result all times formatted in Java on the server have correct short time
zone moniker (EST) - note the job names in the attached screenshot.
At the same time, since Web UI code does not handle time zone names correctly, UI defaults
to using PST when formatting time values - again this can be seen in the same screenshot in
the "Last Modified Time" column.
My expectation is that when moment/moment time zone are integrated, canonical time zone names
will be recognized properly and correct 3-letter time zone abbreviated name would be used
while formatting time values.
I suppose internally UI should carry around an object with at least three attributes - original
tz name specified in the kylin.properties, 3-letter abbreviated tz name and tz offset from
UTC.

More over, if time zone name is incorrect, instead of defaulting to PST, it should default
to UTC. Also, since GMT has been deprecated, all references to GMT (if any left after integrating
support for moment time zone) should be replaced with UTC.

> Add proper time zone support to the WebUI instead of GMT/PST kludge
> -------------------------------------------------------------------
>
>                 Key: KYLIN-3069
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3069
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.2.0
>         Environment: HDP 2.5.3, Kylin 2.2.0
>            Reporter: Vsevolod Ostapenko
>            Assignee: peng.jianhua
>            Priority: Minor
>         Attachments: Screen Shot 2017-12-05 at 10.01.39 PM.png
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Time zone handling logic in the WebUI is a kludge, coded to parse only "GMT-N" time zone
specifications and defaulting to PST, if parsing is not successful (kylin/webapp/app/js/filters/filter.js)
> Integrating moment and moment time zone (http://momentjs.com/timezone/docs/) into the
product, would allow correct time zone handling.
> For the users who happen to reside in the geographical locations that do observe day
light savings time, usage of GMT-N format is very inconvenient and info reported by the UI
in various places is perplexing.
> Needless to say that the GMT moniker itself is long deprecated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message