kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "peng.jianhua (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (KYLIN-3061) When we cancel the Topic modification for 'Kafka Setting' of streaming table, the 'Cancel' operation will make a mistake.
Date Tue, 19 Dec 2017 01:25:00 GMT

     [ https://issues.apache.org/jira/browse/KYLIN-3061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

peng.jianhua closed KYLIN-3061.
-------------------------------
       Resolution: Fixed
    Fix Version/s: v2.3.0

> When we cancel the Topic modification for 'Kafka Setting' of streaming table, the 'Cancel'
operation will make a mistake.
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-3061
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3061
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.3.0
>            Reporter: peng.jianhua
>            Assignee: peng.jianhua
>              Labels: patch
>             Fix For: v2.3.0
>
>         Attachments: 0001-KYLIN-3061-When-we-cancel-the-Topic-modification-for.patch,
MG140.jpeg, MG141.jpeg, MG146.jpeg, after_repaired.png, can_add_the_same_record.png, cancel_is_not_right.png,
edit_kafka_setting.png, edit_streaming_table.png
>
>
> There are two bugs in this issue.
> First
> 1. Choose one streaming table, choose the 'Streaming Cluster' tab, then click 'Edit'
button, refer to [^edit_streaming_table.png]
> 2. The edit page will be opened, then you can edit the value of topic of 'Kafka Setting'.
As long as you modify the ID, Host, Port value, the original value tag will follow changes,
refer to [^edit_kafka_setting.png];
> 3. When you click 'cancel' button, you will find the old values have been changed to
the new values, and if you click the 'submit' button, you will also find the values to be
canceled will be submitted, refer to [^cancel_is_not_right.png]
> But I think the correct way should be that 'cancel' button will not change any value.
> Second
> The follow code in streamingConfig.js has a bug, even if "cluster.newBroker" object matchs
the one element of "cluster.brokers" array, this "if" decision will return false. Because
even though the "cluster.newBroker" object has the same attribute values as an element in
the array, their storage addresses may be different. The result is that you can add several
same record, like [^can_add_the_same_record.png].
> {code:java}
>   $scope.saveNewBroker = function(cluster) {
>     if (cluster.brokers.indexOf(cluster.newBroker) === -1) {
>     ......
>     }
>   }
> {code}
> So I have repaired these two bugs, please check the patch, thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message