kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shaofeng SHI (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-3004) Delete cube segment validation
Date Fri, 08 Dec 2017 08:50:02 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283220#comment-16283220
] 

Shaofeng SHI commented on KYLIN-3004:
-------------------------------------

Hi Julian, one comment: I see you removed that check condition completely; but if report a
warning in log, that would be nice for debugging. Could you update the patch? thanks!

> Delete cube segment validation
> ------------------------------
>
>                 Key: KYLIN-3004
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3004
>             Project: Kylin
>          Issue Type: Bug
>          Components: REST Service
>    Affects Versions: v2.1.0
>            Reporter: Pan, Julian
>            Assignee: Pan, Julian
>         Attachments: KYLIN_3004.patch
>
>
> In version 2.1, kylin allow hole between segment.
> But currently, there is validation for delete segment.
> Here is the code in CubeService:
>  if (!segmentName.equals(cube.getSegments().get(0).getName())
>                 && !segmentName.equals(cube.getSegments().get(cube.getSegments().size()
- 1).getName())) {
>             throw new BadRequestException(String.format(msg.getDELETE_NOT_FIRST_LAST_SEG(),
segmentName));
>         }
> Does it make sense? Should we remove the limit?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message