kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pan, Julian (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-2939) Get config properties not correct in UI
Date Wed, 20 Dec 2017 03:10:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297831#comment-16297831
] 

Pan, Julian commented on KYLIN-2939:
------------------------------------

In the front-end, if I want to get kylin.env, it will return kylin.env.hdfs-working-dir value.
If kylin.env.hdfs-working-dir is before kylin.env.
The code:
 var keyIndex = _config.indexOf(name);
which will get index kylin.env.hdfs-working-dir, cause kylin.env.hdfs-working-dir include
kylin.env.
Then it will return kylin.env.hdfs-working-dir's value instead of kylin.env.
If there is no contain properties, it should works will for the old code. But in 2.1 there
are contain properties, which will produce this issue.
My patch is get index include = and break row:
var keyIndex = _config.indexOf('\n' + name + '=');
Which will resolve this issue.

> Get config properties not correct in UI
> ---------------------------------------
>
>                 Key: KYLIN-2939
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2939
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>            Reporter: Pan, Julian
>            Assignee: Pan, Julian
>            Priority: Critical
>         Attachments: KYLIN_2939.patch
>
>
> When I want to get kylin.env by getDeployEnv(), it will return kylin.env.hdfs-working-dir
value. There is a bug in getProperty in kylinProperties.js.
> This function will return first properties will contains this name.
> Here is the fix:
> this.getProperty = function (name) {
>     var keyIndex = _config.indexOf('\n' + name + '=');
>     var keyLength = name.length;
>     var partialResult = _config.substr(keyIndex);
>     var preValueIndex = partialResult.indexOf("=");
>     var sufValueIndex = partialResult.indexOf("\n", 2);
>     return partialResult.substring(preValueIndex + 1, sufValueIndex);
>   }
> If necessary, I can create a patch for it.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message