kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dong Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-2881) Improve hbase coprocessor exception handling at kylin server side
Date Wed, 13 Dec 2017 09:27:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-2881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288953#comment-16288953
] 

Dong Li commented on KYLIN-2881:
--------------------------------

Hi [~yaho], I'm reviewing the patch, and got a question.

In class KylinTestBase, why added a function call of initExecQueryUsingKylin()? As this is
not needed before your patch.

> Improve hbase coprocessor exception handling at kylin server side 
> ------------------------------------------------------------------
>
>                 Key: KYLIN-2881
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2881
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Query Engine
>            Reporter: Zhong Yanghong
>            Assignee: Zhong Yanghong
>             Fix For: v2.3.0
>
>         Attachments: APACHE-KYLIN-2881.patch
>
>
> A query may need a bunch of hconnections to visit hbase. Anyone of them fails, the whole
query should be interrupted, and all of the related hconnections should be released for future
other queries despite that currently we cannot interrupt the threads at hbase coprocessor
side.
> To achieve this goal, one property is added to QueryContext to keep {{Throwable}}. If
any sub-step during the query detects this {{Throwable}}, it should stop. In {{ExpectedSizeIterator}},
there are two parts where this detection is needed.
> * before putting data to the queue
> * during iteration
> If exception happens during a query, it should stop its related threads. Thus, {{QueryStopListener}}
is added for this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message