kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Billy Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-2975) Unclosed Statement in test
Date Fri, 10 Nov 2017 15:42:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247663#comment-16247663
] 

Billy Liu commented on KYLIN-2975:
----------------------------------

Hi [~liveandevil], you patch could be merged because it's not against the Kylin master. Could
you check if your patch is based on Kylin repo(whose root directory should be kylin)?

> Unclosed Statement in test
> --------------------------
>
>                 Key: KYLIN-2975
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2975
>             Project: Kylin
>          Issue Type: Test
>            Reporter: Ted Yu
>            Assignee: Shengping
>            Priority: Minor
>         Attachments: KYLIN-2975.patch
>
>
> Some Statement resource is not closed in tests.
> e.g. from QuerACLTestUtil.java :
> {code}
>         Statement statement = conn.createStatement();
>         return statement.executeQuery(sql);
> {code}
> The statement should be closed after use.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message