kylin-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Billy Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KYLIN-2796) Remove the legacy "statisticsenabled" codes in FactDistinctColumnsJob
Date Sun, 05 Nov 2017 15:38:00 GMT

    [ https://issues.apache.org/jira/browse/KYLIN-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239589#comment-16239589
] 

Billy Liu commented on KYLIN-2796:
----------------------------------

+1

> Remove the legacy "statisticsenabled" codes in FactDistinctColumnsJob
> ---------------------------------------------------------------------
>
>                 Key: KYLIN-2796
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2796
>             Project: Kylin
>          Issue Type: Improvement
>          Components: Job Engine
>            Reporter: Shaofeng SHI
>            Assignee: Shaofeng SHI
>              Labels: scope
>             Fix For: v2.3.0
>
>
> There are some legacy codes in FactDistinctColumnsJob.java which was for the compitable
with v1.3 and before's Cube, like the checking for whether need collect cube statistics. In
1.5 and later, this option is alreays be true, removing the redundant check will make code
clean.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message