kylin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Created] (KYLIN-3578) Do not synchronize on the intrinsic locks of high-level concurrency objects
Date Sun, 23 Sep 2018 17:28:00 GMT
Ted Yu created KYLIN-3578:
-----------------------------

             Summary: Do not synchronize on the intrinsic locks of high-level concurrency
objects
                 Key: KYLIN-3578
                 URL: https://issues.apache.org/jira/browse/KYLIN-3578
             Project: Kylin
          Issue Type: Bug
            Reporter: Ted Yu


>From core-common/src/main/java/org/apache/kylin/common/util/MemoryBudgetController.java
:
{code}
    private final ReentrantLock lock = new ReentrantLock();
...
            synchronized (lock) {
{code}
See the following for why such practice is to be avoided:

https://wiki.sei.cmu.edu/confluence/display/java/LCK03-J.+Do+not+synchronize+on+the+intrinsic+locks+of+high-level+concurrency+objects



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message