kylin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] shaofengshi closed pull request #252: KYLIN-3580 Avoid using entrySet to add elements
Date Wed, 26 Sep 2018 10:55:15 GMT
shaofengshi closed pull request #252: KYLIN-3580 Avoid using entrySet to add elements
URL: https://github.com/apache/kylin/pull/252
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java
b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java
index c2683df993..def1e68116 100644
--- a/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java
+++ b/core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java
@@ -87,7 +87,10 @@ public int compare(Map.Entry<Long, Long> o1, Map.Entry<Long, Long>
o2) {
                         return o1.getValue().compareTo(o2.getValue());
                     }
                 });
-        sortedStatsSet.addAll(statistics.entrySet());
+        //sortedStatsSet.addAll(statistics.entrySet()); KYLIN-3580
+        for(Map.Entry<Long, Long> entry : statistics.entrySet()){
+            sortedStatsSet.add(entry);
+        }
         for (Long cuboid : mandatoryCuboidSet) {
             if (statistics.get(cuboid) == null) {
                 // Get estimate row count for mandatory cuboid


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message