kylin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rogercloud commented on a change in pull request #135: KYLIN-3347 : calcite function QueryService Exception
Date Thu, 26 Apr 2018 02:35:02 GMT
rogercloud commented on a change in pull request #135: KYLIN-3347 : calcite function QueryService
Exception
URL: https://github.com/apache/kylin/pull/135#discussion_r184256469
 
 

 ##########
 File path: query/src/main/java/org/apache/kylin/query/util/DefaultQueryTransformer.java
 ##########
 @@ -138,6 +140,12 @@ public String transform(String sql, String project, String defaultSchema)
{
             sql = sql.substring(0, m.start(1)) + "'" + value + "'" + sql.substring(m.end(3));
         }
 
+        while (true) {
 
 Review comment:
   Please add some comments to explain how the pattern is used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message