kylin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Xiaoyu Wang <wangxiao...@jd.com>
Subject Re: [VOTE] Release apache-kylin-1.1.1-incubating (release candidate 1)
Date Thu, 05 Nov 2015 01:52:30 GMT
+1 non binding
md5&sha1 is OK.
mvn test is OK.


在 2015年11月05日 09:44, hongbin ma 写道:
> +1
>
> mvn test passed
>
> On Thu, Nov 5, 2015 at 9:09 AM, Luke Han <luke.hq@gmail.com> wrote:
>
>> Thanks Julian, just refined the comments there as below:
>>
>> Google fonts have been excluded from the source code, pom and also cleaned
>> up files,
>> main commit is here:
>>
>> https://github.com/apache/incubator-kylin/commit/a2fa3e8e93765bf3db39f5da935aca3a588789f1
>>
>> and will keep license file's content as current one, once merge to other
>> branch especially for 1.x-staging (main dev branch) will remove section
>> about Google and Adobe fonts which added previous.
>>
>> v1.1.1 already rolled out for vote now.
>>
>> Will close this ticket once vote pass in IPMC.
>>
>> Thanks.
>>
>>
>> Best Regards!
>> ---------------------
>>
>> Luke Han
>>
>> On Thu, Nov 5, 2015 at 5:08 AM, Julian Hyde <jhyde@apache.org> wrote:
>>
>>> +1
>>>
>>> Downloaded, built on JDK 1.8/ubuntu, checked hashes, license, notice.
>>>
>>> As an aside on your development process. It was difficult for me to make
>>> sure that the fix for KYLIN-999 had made it into the code, in full.
>> Luke’s
>>> comment in KYLIN-999 does not reference a commit number. There are
>> several
>>> commits in
>> https://github.com/apache/incubator-kylin/commits/v1.1-release
>>> <https://github.com/apache/incubator-kylin/commits/v1.1-release> with
>>> “KYLIN-999” in the comment, but it is not clear that they constitute the
>>> whole fix. Luke’s comment says "updated license file, pom and also
>> cleaned
>>> up files” when in fact LICENSE has not been changed in 5 months.
>>>
>>> I deduce that the fix was to remove the offending fonts, and no change to
>>> the license file was required, and therefore everything is fine. Still,
>>> Luke’s comment was misleading. Licensing stuff needs to be bullet proof,
>> so
>>> we need a clear audit trail. I suggest including a commit URL whenever a
>>> bug is fixed, especially bugs as important as this one, so that people
>> not
>>> familiar with the bug can more easily review.
>>>
>>> Julian
>>>
>>>
>>>> On Nov 4, 2015, at 8:35 AM, Jian Zhong <hellowode110@gmail.com> wrote:
>>>>
>>>> +1 binding
>>>> md5&sha1 passed
>>>> mvn test passed
>>>>
>>>> On Wed, Nov 4, 2015 at 8:53 PM, 周千昊 <qhzhou@apache.org> wrote:
>>>>
>>>>> +1 binding
>>>>> mvn test passed
>>>>> md5 sha1 passed
>>>>>
>>>>> Luke Han <luke.hq@gmail.com>于2015年11月4日周三 下午8:22写道:
>>>>>
>>>>>> Thanks Shaofeng.
>>>>>>
>>>>>> +1 binding
>>>>>>
>>>>>> I checked:
>>>>>>     - artefact has incubating in name
>>>>>>     - signatures and hashes good
>>>>>>     - DISCLAIMER/LICENSE/NOTICE are good
>>>>>>     - All source files have Apache headers
>>>>>>     - No unexpected binary file in source release (but see below)
>>>>>>     - can compile from source
>>>>>>     - mvn test pass
>>>>>>
>>>>>>     OS: Mac X EI Capitan, 10.11.1
>>>>>>     Jave: 1.7.0_75 64bit
>>>>>>     Maven: 3.2.5
>>>>>>
>>>>>>     Thanks.
>>>>>>
>>>>>> Luke
>>>>>>
>>>>>>
>>>>>> Best Regards!
>>>>>> ---------------------
>>>>>>
>>>>>> Luke Han
>>>>>>
>>>>>> On Wed, Nov 4, 2015 at 7:59 PM, ShaoFeng Shi <shaofengshi@apache.org
>>>>>> wrote:
>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>> I have created a build for Apache Kylin 1.1.1-incubating, release
>>>>>> candidate
>>>>>>> 1.
>>>>>>>
>>>>>>> This release only includes license cleanup, no Java code change;
>>>>>>> For more information please check KYLIN-999.
>>>>>>>
>>>>>>> Thanks to everyone who has contributed to this release.
>>>>>>> Here’s release notes:
>>>>>>> https://kylin.incubator.apache.org/docs/release_notes.html
>>>>>>>
>>>>>>> The commit to be voted upon:
>>>>>>>
>>>>>>>
>>>>>>>
>> https://github.com/apache/incubator-kylin/commit/708ea38d7f764048e67e8e1ee8a13955983d12ba
>>>>>>> Its hash is 708ea38d7f764048e67e8e1ee8a13955983d12ba.
>>>>>>>
>>>>>>> The artifacts to be voted on are located here:
>>>>>>>
>>>>>>>
>> https://dist.apache.org/repos/dist/dev/incubator/kylin/apache-kylin-1.1.1-incubating-rc1/
>>>>>>> The hashes of the artifacts are as follows:
>>>>>>> apache-kylin-1.1.1-incubating-src.tar.gz.md5
>>>>>>> ff942b2eba870b04552bc8c8dace5517
>>>>>>> apache-kylin-1.1.1-incubating-src.tar.gz.sha1
>>>>>>> cc8990ba7821b02f4bf6da5f870b30a915881535
>>>>>>>
>>>>>>> A staged Maven repository is available for review at:
>>>>>>>
>> https://repository.apache.org/content/repositories/orgapachekylin-1013/
>>>>>>> Release artifacts are signed with the following key:
>>>>>>> https://people.apache.org/keys/committer/shaofengshi.asc
>>>>>>>
>>>>>>> Please vote on releasing this package as Apache Kylin
>>> 1.1.1-incubating.
>>>>>>> The vote is open for the next 48 hours and passes if a majority
of
>>>>>>> at least three +1 PPMC votes are cast.
>>>>>>>
>>>>>>> [ ] +1 Release this package as Apache Kylin 1.1.1-incubating
>>>>>>> [ ]  0 I don't feel strongly about it, but I'm okay with the
release
>>>>>>> [ ] -1 Do not release this package because...
>>>>>>>
>>>>>>>
>>>>>>> Here is my vote:
>>>>>>>
>>>>>>> +1 (binding)
>>>>>>>
>>>>>>> --
>>>>>>> Best regards,
>>>>>>>
>>>>>>> Shaofeng Shi
>>>>>>>
>>>
>
>


Mime
View raw message