Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3024F200D2F for ; Wed, 18 Oct 2017 03:14:46 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2E8EC1609EC; Wed, 18 Oct 2017 01:14:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 735ED1609EB for ; Wed, 18 Oct 2017 03:14:45 +0200 (CEST) Received: (qmail 39908 invoked by uid 500); 18 Oct 2017 01:14:44 -0000 Mailing-List: contact commits-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list commits@kylin.apache.org Received: (qmail 39899 invoked by uid 99); 18 Oct 2017 01:14:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2017 01:14:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7ECA1DFA0A; Wed, 18 Oct 2017 01:14:43 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: shaofengshi@apache.org To: commits@kylin.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: kylin git commit: KYLIN-2944 HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in serialize Date: Wed, 18 Oct 2017 01:14:43 +0000 (UTC) archived-at: Wed, 18 Oct 2017 01:14:46 -0000 Repository: kylin Updated Branches: refs/heads/master 8891b1c84 -> 3efa9b4fe KYLIN-2944 HLLCSerializer, RawSerializer, PercentileSerializer returns shared object in serialize Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/3efa9b4f Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/3efa9b4f Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/3efa9b4f Branch: refs/heads/master Commit: 3efa9b4fe17623af1d42ba09b389dabef73d789e Parents: 8891b1c Author: shaofengshi Authored: Tue Oct 17 22:30:42 2017 +0800 Committer: shaofengshi Committed: Wed Oct 18 09:14:40 2017 +0800 ---------------------------------------------------------------------- .../main/java/org/apache/kylin/measure/hllc/HLLCSerializer.java | 2 +- .../org/apache/kylin/measure/percentile/PercentileSerializer.java | 2 +- .../src/main/java/org/apache/kylin/measure/raw/RawSerializer.java | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/3efa9b4f/core-metadata/src/main/java/org/apache/kylin/measure/hllc/HLLCSerializer.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/measure/hllc/HLLCSerializer.java b/core-metadata/src/main/java/org/apache/kylin/measure/hllc/HLLCSerializer.java index df0cfaf..ddf8281 100644 --- a/core-metadata/src/main/java/org/apache/kylin/measure/hllc/HLLCSerializer.java +++ b/core-metadata/src/main/java/org/apache/kylin/measure/hllc/HLLCSerializer.java @@ -56,7 +56,7 @@ public class HLLCSerializer extends DataTypeSerializer { @Override public HLLCounter deserialize(ByteBuffer in) { - HLLCounter hllc = current(); + HLLCounter hllc = new HLLCounter(precision); try { hllc.readRegisters(in); } catch (IOException e) { http://git-wip-us.apache.org/repos/asf/kylin/blob/3efa9b4f/core-metadata/src/main/java/org/apache/kylin/measure/percentile/PercentileSerializer.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/measure/percentile/PercentileSerializer.java b/core-metadata/src/main/java/org/apache/kylin/measure/percentile/PercentileSerializer.java index d7e4204..35230a2 100644 --- a/core-metadata/src/main/java/org/apache/kylin/measure/percentile/PercentileSerializer.java +++ b/core-metadata/src/main/java/org/apache/kylin/measure/percentile/PercentileSerializer.java @@ -68,7 +68,7 @@ public class PercentileSerializer extends DataTypeSerializer @Override public PercentileCounter deserialize(ByteBuffer in) { - PercentileCounter counter = current(); + PercentileCounter counter = new PercentileCounter(compression); counter.readRegisters(in); return counter; } http://git-wip-us.apache.org/repos/asf/kylin/blob/3efa9b4f/core-metadata/src/main/java/org/apache/kylin/measure/raw/RawSerializer.java ---------------------------------------------------------------------- diff --git a/core-metadata/src/main/java/org/apache/kylin/measure/raw/RawSerializer.java b/core-metadata/src/main/java/org/apache/kylin/measure/raw/RawSerializer.java index 68a0273..ea3f376 100644 --- a/core-metadata/src/main/java/org/apache/kylin/measure/raw/RawSerializer.java +++ b/core-metadata/src/main/java/org/apache/kylin/measure/raw/RawSerializer.java @@ -90,8 +90,7 @@ public class RawSerializer extends DataTypeSerializer> { @Override public List deserialize(ByteBuffer in) { - List values = current(); - values.clear(); + List values = new ArrayList<>(); int size = BytesUtil.readVInt(in); if (size >= 0) { for (int i = 0; i < size; i++) {