kylin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liy...@apache.org
Subject [01/15] kylin git commit: minor but important, ColumnDesc.equals() check only table and name [Forced Update!]
Date Fri, 09 Dec 2016 04:25:43 GMT
Repository: kylin
Updated Branches:
  refs/heads/master-cdh5.7 bfc89a0f7 -> 0b71be997 (forced update)


minor but important, ColumnDesc.equals() check only table and name


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/8b646206
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/8b646206
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/8b646206

Branch: refs/heads/master-cdh5.7
Commit: 8b64620631200a724117dec97e3c69c19d9cf22c
Parents: 4c39fcb
Author: Li Yang <liyang@apache.org>
Authored: Thu Dec 8 14:48:11 2016 +0800
Committer: Li Yang <liyang@apache.org>
Committed: Thu Dec 8 14:48:11 2016 +0800

----------------------------------------------------------------------
 .../main/java/org/apache/kylin/metadata/model/ColumnDesc.java  | 6 ------
 1 file changed, 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/8b646206/core-metadata/src/main/java/org/apache/kylin/metadata/model/ColumnDesc.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/model/ColumnDesc.java b/core-metadata/src/main/java/org/apache/kylin/metadata/model/ColumnDesc.java
index 403eaaf..2da1f5e 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/model/ColumnDesc.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/model/ColumnDesc.java
@@ -197,12 +197,6 @@ public class ColumnDesc implements Serializable {
         } else if (!table.getIdentity().equals(other.table.getIdentity()))
             return false;
         
-        if (datatype == null) {
-            if (other.datatype != null)
-                return false;
-        } else if (!datatype.equals(other.datatype))
-            return false;
-
         return true;
     }
 


Mime
View raw message