kylin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From billy...@apache.org
Subject kylin git commit: revert Bytes toString()
Date Fri, 30 Dec 2016 05:57:58 GMT
Repository: kylin
Updated Branches:
  refs/heads/fix-sonar 3d8f1a505 -> 37f511d47


revert Bytes toString()


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/37f511d4
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/37f511d4
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/37f511d4

Branch: refs/heads/fix-sonar
Commit: 37f511d478584938ddf3bf12a8a69b511e242162
Parents: 3d8f1a5
Author: Billy Liu <billyliu@apache.org>
Authored: Fri Dec 30 13:57:44 2016 +0800
Committer: Billy Liu <billyliu@apache.org>
Committed: Fri Dec 30 13:57:44 2016 +0800

----------------------------------------------------------------------
 .../src/main/java/org/apache/kylin/common/util/ByteArray.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/37f511d4/core-common/src/main/java/org/apache/kylin/common/util/ByteArray.java
----------------------------------------------------------------------
diff --git a/core-common/src/main/java/org/apache/kylin/common/util/ByteArray.java b/core-common/src/main/java/org/apache/kylin/common/util/ByteArray.java
index cbe32b3..db9fc80 100644
--- a/core-common/src/main/java/org/apache/kylin/common/util/ByteArray.java
+++ b/core-common/src/main/java/org/apache/kylin/common/util/ByteArray.java
@@ -185,7 +185,7 @@ public class ByteArray implements Comparable<ByteArray>, Serializable
{
 
     public String toReadableText() {
         if (data == null) {
-            return "";
+            return null;
         } else {
             return BytesUtil.toHex(data, offset, length);
         }
@@ -194,7 +194,7 @@ public class ByteArray implements Comparable<ByteArray>, Serializable
{
     @Override
     public String toString() {
         if (data == null)
-            return "";
+            return null;
         else
             return Bytes.toStringBinary(data, offset, length);
     }


Mime
View raw message