kylin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liy...@apache.org
Subject kylin git commit: KYLIN-1851 Treat empty dictionary as a normal case
Date Sat, 19 Nov 2016 12:09:48 GMT
Repository: kylin
Updated Branches:
  refs/heads/master 2b2eb3405 -> 634aeaa94


KYLIN-1851 Treat empty dictionary as a normal case


Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/634aeaa9
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/634aeaa9
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/634aeaa9

Branch: refs/heads/master
Commit: 634aeaa9486171bb816a738794f136c0d1936c92
Parents: 2b2eb34
Author: Yang Li <liyang@apache.org>
Authored: Sat Nov 19 20:09:29 2016 +0800
Committer: Yang Li <liyang@apache.org>
Committed: Sat Nov 19 20:09:29 2016 +0800

----------------------------------------------------------------------
 .../main/java/org/apache/kylin/dict/TrieDictionaryForest.java   | 5 -----
 1 file changed, 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kylin/blob/634aeaa9/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionaryForest.java
----------------------------------------------------------------------
diff --git a/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionaryForest.java
b/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionaryForest.java
index 6525fe5..1015b11 100755
--- a/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionaryForest.java
+++ b/core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionaryForest.java
@@ -32,8 +32,6 @@ import org.apache.kylin.common.util.Bytes;
 import org.apache.kylin.common.util.BytesUtil;
 import org.apache.kylin.common.util.ClassUtil;
 import org.apache.kylin.common.util.Dictionary;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Use trie forest to optimize trie dictionary
@@ -57,8 +55,6 @@ public class TrieDictionaryForest<T> extends Dictionary<T> {
 
     private ArrayList<ByteArray> maxValue;
 
-    private static final Logger logger = LoggerFactory.getLogger(TrieDictionaryForest.class);
-
     public TrieDictionaryForest() { // default constructor for Writable interface
     }
 
@@ -377,7 +373,6 @@ public class TrieDictionaryForest<T> extends Dictionary<T>
{
     private void initMaxValue() throws IllegalStateException {
         this.maxValue = new ArrayList<>();
         if (this.trees == null || trees.isEmpty()) {
-            logger.info("Trees not init yet or trees size is zero. Could not init max value
of each tree");
             return;
         }
         for (int i = 0; i < trees.size(); i++) {


Mime
View raw message