Return-Path: X-Original-To: apmail-kylin-commits-archive@minotaur.apache.org Delivered-To: apmail-kylin-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19E13199EF for ; Mon, 18 Apr 2016 06:34:44 +0000 (UTC) Received: (qmail 38801 invoked by uid 500); 18 Apr 2016 06:34:44 -0000 Delivered-To: apmail-kylin-commits-archive@kylin.apache.org Received: (qmail 38710 invoked by uid 500); 18 Apr 2016 06:34:43 -0000 Mailing-List: contact commits-help@kylin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kylin.apache.org Delivered-To: mailing list commits@kylin.apache.org Received: (qmail 38584 invoked by uid 99); 18 Apr 2016 06:34:43 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Apr 2016 06:34:43 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7FB5BDFD43; Mon, 18 Apr 2016 06:34:43 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: nju_yaho@apache.org To: commits@kylin.apache.org Date: Mon, 18 Apr 2016 06:34:45 -0000 Message-Id: In-Reply-To: <50a0aa8ee32b4c129472bc8d08b6df38@git.apache.org> References: <50a0aa8ee32b4c129472bc8d08b6df38@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [03/50] kylin git commit: KYLIN-1420 Query returns empty result on partition column's boundary condition KYLIN-1420 Query returns empty result on partition column's boundary condition Project: http://git-wip-us.apache.org/repos/asf/kylin/repo Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/8880740d Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/8880740d Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/8880740d Branch: refs/heads/1.4-rc Commit: 8880740d598802595edb1ed89f8e0d75b3a38d6a Parents: ebce31e Author: shaofengshi Authored: Mon Feb 15 15:52:15 2016 +0800 Committer: shaofengshi Committed: Mon Feb 15 15:52:15 2016 +0800 ---------------------------------------------------------------------- .../main/java/org/apache/kylin/gridtable/GTScanRangePlanner.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kylin/blob/8880740d/core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRangePlanner.java ---------------------------------------------------------------------- diff --git a/core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRangePlanner.java b/core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRangePlanner.java index 837abf0..7551e49 100644 --- a/core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRangePlanner.java +++ b/core-cube/src/main/java/org/apache/kylin/gridtable/GTScanRangePlanner.java @@ -126,8 +126,8 @@ public class GTScanRangePlanner { for (ColumnRange range : andDimRanges) { if (partitionColRef != null && range.column.equals(partitionColRef)) { if (rangeStartEndComparator.comparator.compare(segmentStartAndEnd.getFirst(), range.end) <= 0 // - && rangeStartEndComparator.comparator.compare(range.begin, segmentStartAndEnd.getSecond()) < 0) { - //segment range is [Closed,Open) + && rangeStartEndComparator.comparator.compare(range.begin, segmentStartAndEnd.getSecond()) <= 0) { + //segment range is [Closed,Open), but segmentStartAndEnd.getSecond() might be rounded, so use <=. } else { logger.debug("Pre-check partition col filter failed, partitionColRef {}, segment start {}, segment end {}, range begin {}, range end {}",// new Object[] { partitionColRef, makeReadable(segmentStartAndEnd.getFirst()), makeReadable(segmentStartAndEnd.getSecond()), makeReadable(range.begin), makeReadable(range.end) });