kylin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaofeng...@apache.org
Subject incubator-kylin git commit: KYLIN-1025 Save cube change is very slow
Date Tue, 29 Sep 2015 05:57:53 GMT
Repository: incubator-kylin
Updated Branches:
  refs/heads/1.x-staging 20f6eaf69 -> 67322634a


KYLIN-1025 Save cube change is very slow

Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/67322634
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/67322634
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/67322634

Branch: refs/heads/1.x-staging
Commit: 67322634a767dd7efcbcf3ea5fb879e52c9ce559
Parents: 20f6eaf
Author: shaofengshi <shaofengshi@apache.org>
Authored: Tue Sep 29 13:55:51 2015 +0800
Committer: shaofengshi <shaofengshi@apache.org>
Committed: Tue Sep 29 13:55:51 2015 +0800

----------------------------------------------------------------------
 .../main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java    | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/67322634/cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java
----------------------------------------------------------------------
diff --git a/cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java b/cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java
index 54320e1..8d53000 100644
--- a/cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java
+++ b/cube/src/main/java/org/apache/kylin/cube/cuboid/CuboidCLI.java
@@ -65,14 +65,16 @@ public class CuboidCLI {
             }
         }
 
+        /** disable this due to poor performance when dimension number is big
         TreeSet<Long> enumCuboids = enumCalcCuboidCount(cube);
         if (enumCuboids.equals(cuboidSet) == false) {
             throw new IllegalStateException("Expected cuboid set " + enumCuboids + "; but
actual cuboid set " + cuboidSet);
         }
-
+         **/
+        
         int mathCount = mathCalcCuboidCount(cube);
-        if (mathCount != enumCuboids.size()) {
-            throw new IllegalStateException("Math cuboid count " + mathCount + ", but actual
cuboid count " + enumCuboids.size());
+        if (mathCount != cuboidSet.size()) {
+            throw new IllegalStateException("Math cuboid count " + mathCount + ", but actual
cuboid count " + cuboidSet.size());
         }
 
         return mathCount;


Mime
View raw message