kylin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liy...@apache.org
Subject [31/50] [abbrv] incubator-kylin git commit: fix filter 0 bytes bug , when bytes is 0 show '0 bytes' KYLIN-572
Date Sat, 14 Mar 2015 00:02:16 GMT
fix filter 0 bytes bug
, when bytes is 0 show '0 bytes' KYLIN-572


Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/7dae30ef
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/7dae30ef
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/7dae30ef

Branch: refs/heads/staging
Commit: 7dae30ef66b4132b84b4fcc4b635b838af5aaffb
Parents: ec0fb0f
Author: jiazhong <jiazhong@ebay.com>
Authored: Tue Mar 10 15:25:37 2015 +0800
Committer: jiazhong <jiazhong@ebay.com>
Committed: Tue Mar 10 15:25:37 2015 +0800

----------------------------------------------------------------------
 webapp/app/js/controllers/cubeAdvanceSetting.js | 1 +
 webapp/app/js/filters/filter.js                 | 1 +
 2 files changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/7dae30ef/webapp/app/js/controllers/cubeAdvanceSetting.js
----------------------------------------------------------------------
diff --git a/webapp/app/js/controllers/cubeAdvanceSetting.js b/webapp/app/js/controllers/cubeAdvanceSetting.js
index 4c30905..f1bd991 100644
--- a/webapp/app/js/controllers/cubeAdvanceSetting.js
+++ b/webapp/app/js/controllers/cubeAdvanceSetting.js
@@ -27,6 +27,7 @@ KylinApp.controller('CubeAdvanceSettingCtrl', function ($scope, $modal,cubeConfi
             }
         }
     );
+    //edit model
     if($scope.state.mode==="edit") {
         $scope.metaModel = MetaModel;
     }

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/7dae30ef/webapp/app/js/filters/filter.js
----------------------------------------------------------------------
diff --git a/webapp/app/js/filters/filter.js b/webapp/app/js/filters/filter.js
index f3364c7..555e31d 100755
--- a/webapp/app/js/filters/filter.js
+++ b/webapp/app/js/filters/filter.js
@@ -83,6 +83,7 @@ KylinApp
     // Convert bytes into human readable format.
     .filter('bytes', function() {
         return function(bytes, precision) {
+            if (bytes === 0) { return '0 bytes' };
             if (isNaN(parseFloat(bytes)) || !isFinite(bytes)) {
                 return '-';
             }


Mime
View raw message