kylin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liy...@apache.org
Subject [49/53] [abbrv] incubator-kylin git commit: fix cube designer bug
Date Sat, 31 Jan 2015 11:57:47 GMT
fix cube designer bug


Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/19360602
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/19360602
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/19360602

Branch: refs/heads/master
Commit: 193606021ce570339c6bb21f2c1578a74f783476
Parents: 69395e7
Author: jiazhong <jiazhong@ebay.com>
Authored: Mon Jan 26 18:40:00 2015 -0800
Committer: jiazhong <jiazhong@ebay.com>
Committed: Mon Jan 26 18:40:00 2015 -0800

----------------------------------------------------------------------
 webapp/app/js/controllers/cubeEdit.js  | 2 +-
 webapp/app/js/directives/directives.js | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/19360602/webapp/app/js/controllers/cubeEdit.js
----------------------------------------------------------------------
diff --git a/webapp/app/js/controllers/cubeEdit.js b/webapp/app/js/controllers/cubeEdit.js
index 94e92da..2875107 100644
--- a/webapp/app/js/controllers/cubeEdit.js
+++ b/webapp/app/js/controllers/cubeEdit.js
@@ -53,7 +53,7 @@ KylinApp.controller('CubeEditCtrl', function ($scope, $q, $routeParams,
$locatio
     $scope.srcTablesInProject = [];
 
     $scope.getColumnsByTable = function (name) {
-        var temp = null;
+        var temp = [];
         angular.forEach($scope.srcTablesInProject, function (table) {
             if (table.name == name) {
                 temp = table.columns;

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/19360602/webapp/app/js/directives/directives.js
----------------------------------------------------------------------
diff --git a/webapp/app/js/directives/directives.js b/webapp/app/js/directives/directives.js
index 723567f..264cb05 100644
--- a/webapp/app/js/directives/directives.js
+++ b/webapp/app/js/directives/directives.js
@@ -47,9 +47,6 @@ KylinApp.directive('kylinPagination', function ($parse, $q) {
 
             scope.reload = function () {
                 var length = scope.getLength(scope.data);
-                if(!length){
-                    return;
-                }
                 scope.loadFunc(0, scope.limit).then(function (dataLength) {
                     scope.data = $parse(attrs.data)(scope.$parent);
                     scope.hasMore = dataLength == scope.limit;


Mime
View raw message