From reviews-return-58363-archive-asf-public=cust-asf.ponee.io@kudu.apache.org Tue Jun 30 18:51:56 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 99362180643 for ; Tue, 30 Jun 2020 20:51:56 +0200 (CEST) Received: (qmail 7770 invoked by uid 500); 30 Jun 2020 18:51:56 -0000 Mailing-List: contact reviews-help@kudu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@kudu.apache.org Delivered-To: mailing list reviews@kudu.apache.org Received: (qmail 7758 invoked by uid 99); 30 Jun 2020 18:51:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jun 2020 18:51:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 0A65F1A3347 for ; Tue, 30 Jun 2020 18:51:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.824 X-Spam-Level: X-Spam-Status: No, score=0.824 tagged_above=-999 required=6.31 tests=[FREEMAIL_REPLYTO_END_DIGIT=0.25, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ViLstrWtopBD for ; Tue, 30 Jun 2020 18:51:53 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 8FBC7BC09A for ; Tue, 30 Jun 2020 18:51:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 05UIpqeb017172; Tue, 30 Jun 2020 18:51:52 GMT Message-Id: <202006301851.05UIpqeb017172@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 1 Date: Tue, 30 Jun 2020 18:51:52 +0000 From: "Bankim Bhavsar (Code Review)" To: reviews@kudu.apache.org CC: Todd Lipcon , Alexey Serbin , Grant Henke X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5Bkudu-CR=5D_=5Bdocs=5D=5Bdocker=5D_KUDU-3159_Fix_missing_devtoolset3_package_on_el6=0A?= X-Gerrit-Change-Id: I9c4b9546c835df26f993ed6164e92f2d4c55c3fe X-Gerrit-Change-Number: 16114 X-Gerrit-ChangeURL: X-Gerrit-Commit: a9bc3200a6b6230f9cd4873fd7853b0ddd1c1015 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 30 Jun 2020 18:51:52 +0000 Reply-To: bankim@cloudera.com, reviews@kudu.apache.org, granthenke@apache.org, smcintosh@cloudera.com, todd@apache.org, aserbin@cloudera.com, ritwik.yadav@gmail.com, chuchao333@gmail.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="dLSYfozeDHI="; charset=UTF-8 --dLSYfozeDHI= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Bankim Bhavsar has posted comments on this change=2E ( http://gerrit=2Eclou= dera=2Eorg:8080/16114 ) Change subject: [docs][docker] KUDU-3159 Fix missi= ng devtoolset3 package on el6 =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E Patch Set 1: > Patch Set 1: > > > Patch Set 1: > > > >= We can publish documentation outside of a release=2E > > > > I think upd= ating the enable_devtoolset scripts is the main thing, but there could be o= thers=2E I would grep for other occurrences of "devtoolset" in the codebase= =2E > > Update: Plan of action is to recommend using higher version of dev= toolset for el6=2E > > Tried using devtoolset-8 on CentOS6=2E10, however t= hirdparty build fails in python2=2E7=2E I'll try a lower version of devtool= set=2E If I hit same python2=2E7 issue will try debugging it=2E > > gcc -= pthread -Xlinker -export-dynamic -o python \ > Modules/python=2Eo \ > = libpython2=2E7=2Ea -lpthread -ldl -lutil -lm > libpython2=2E7=2Ea(posixm= odule=2Eo): In function `posix_tmpnam': > /root/src/kudu/thirdparty/src/pyt= hon-2=2E7=2E13/Modules/posixmodule=2Ec:7614: warning: the use of `tmpnam_r'= is dangerous, better use `mkstemp' > libpython2=2E7=2Ea(posixmodule=2Eo): = In function `posix_tempnam': > /root/src/kudu/thirdparty/src/python-2=2E7= =2E13/Modules/posixmodule=2Ec:7561: warning: the use of `tempnam' is danger= ous, better use `mkstemp' > =2E/python -E -S -m sysconfig --generate-posix-= vars ;\ > if test $? -ne 0 ; then \ > echo "generate-posix-vars failed" ; = \ > rm -f =2E/pybuilddir=2Etxt ; \ > exit 1 ; \ > fi > /bin/sh: line 5: 7= 6967 Segmentation fault (core dumped) =2E/python -E -S -m sysconfig --= generate-posix-vars > generate-posix-vars failed > make: *** [Makefile:543:= pybuilddir=2Etxt] Error 1 Filed KUDU-3160 to track upgrading devtoolset v= ersion for el6=2E Since el6 is EOL soon in Nov 2020 [1] and kudu version 1= =2E12 already marked el6 as deprecated [2] don't see much of a point in pur= suing upgrade of devtoolset as urgent/critical=2E [1] https://wiki=2Ecento= s=2Eorg/FAQ/General#What_is_the_support_=2E27=2E27end_of_life=2E27=2E27_for= _each_CentOS_release=2E3F [2] https://kudu=2Eapache=2Eorg/releases/1=2E12= =2E0/docs/release_notes=2Ehtml#rn_1=2E12=2E0_obsoletions -- To view, vis= it http://gerrit=2Ecloudera=2Eorg:8080/16114 To unsubscribe, visit http://g= errit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: kudu Gerrit-Branch: m= aster Gerrit-MessageType: comment Gerrit-Change-Id: I9c4b9546c835df26f993ed= 6164e92f2d4c55c3fe Gerrit-Change-Number: 16114 Gerrit-PatchSet: 1 Gerrit-Ow= ner: Bankim Bhavsar Gerrit-Reviewer: Alexey Serbin = Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Revie= wer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Ge= rrit-Comment-Date: Tue, 30 Jun 2020 18:51:52 +0000 Gerrit-HasComments: No --dLSYfozeDHI=--