kudu-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Solovyev (Code Review)" <ger...@cloudera.org>
Subject [kudu-CR] KUDU-3090 Ownership support in Java client
Date Tue, 30 Jun 2020 23:27:21 GMT
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/16125 )

Change subject: KUDU-3090 Ownership support in Java client
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java
File java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java:

http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/main/java/org/apache/kudu/client/CreateTableOptions.java@a262
PS3, Line 262: 
why delete this check?


http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java:

http://gerrit.cloudera.org:8080/#/c/16125/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHiveMetastoreIntegration.java@a32
PS3, Line 32: 
I am not sure why you are deleting this test. Are we still planning to synchronize owner information
between HMS and Kudu metadata?



-- 
To view, visit http://gerrit.cloudera.org:8080/16125
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I083ad9750ce1b3ae31bb510b700d1204fcdf291d
Gerrit-Change-Number: 16125
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <abukor@apache.org>
Gerrit-Reviewer: Greg Solovyev <gsolovyev@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Jun 2020 23:27:21 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message