kudu-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Bukor (Code Review)" <ger...@cloudera.org>
Subject [kudu-CR] KUDU-3090 Restrict changing ownership of a table
Date Tue, 30 Jun 2020 14:42:10 GMT
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16113 )

Change subject: KUDU-3090 Restrict changing ownership of a table
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16113/2/src/kudu/integration-tests/master_authz-itest.cc
File src/kudu/integration-tests/master_authz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/16113/2/src/kudu/integration-tests/master_authz-itest.cc@1044
PS2, Line 1044: GrantAllWithGrantTablePrivilege,
> But don't we only need ALL WITH GRANT on table?
You're right.


http://gerrit.cloudera.org:8080/#/c/16113/2/src/kudu/master/authz_provider.h
File src/kudu/master/authz_provider.h:

http://gerrit.cloudera.org:8080/#/c/16113/2/src/kudu/master/authz_provider.h@117
PS2, Line 117:   // 'is_owner' indicates whether 'user' is the current owner of t
> nit: maybe reword so it's more pertinent to this interface, e.g. "'is_owner
Done


http://gerrit.cloudera.org:8080/#/c/16113/2/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16113/2/src/kudu/master/catalog_manager.cc@2573
PS2, Line 2573:     const string new_table = req.has_new_table_name() ?
              :         NormalizeTableName(req.new_table_name()) : table_name;
              :     if (req.has_new_table_owner()) {
> We shouldn't have to do this if we're changing owners, right?
Yep you're right.



-- 
To view, visit http://gerrit.cloudera.org:8080/16113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75a8b24364572a84f93826ad670c543abd407bb1
Gerrit-Change-Number: 16113
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <abukor@apache.org>
Gerrit-Reviewer: Andrew Wong <awong@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abukor@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 30 Jun 2020 14:42:10 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message