kudu-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Attila Bukor (Code Review)" <ger...@cloudera.org>
Subject [kudu-CR] KUDU-3090 Add ownership privileges
Date Tue, 30 Jun 2020 14:42:05 GMT
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16072 )

Change subject: KUDU-3090 Add ownership privileges
......................................................................


Patch Set 8:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/authz_provider.h
File src/kudu/master/authz_provider.h:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/authz_provider.h@94
PS7, Line 94: is_owner_by
> nit: maybe call this 'is_owner_by_table_name' or something
Done


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@1939
PS7, Line 1939: mismatched_table = true;
> Maybe consider populating some scoped_refptr<TableInfo> table_with_mismatch
Hm isn't this out of scope for this patch and feature? Maybe it would be better to file a
JIRA and work on this separately?


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@1957
PS7, Line 1957:       // if the table doesn't exist, we don't have ownership information to
pass
> nit: may be obvious, but it's a little jarring to see empty strings. Maybe 
Done


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/master/catalog_manager.cc@2960
PS7, Line 2960: 
> nit: can use *user
Done


http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/ranger/ranger_client-test.cc
File src/kudu/ranger/ranger_client-test.cc:

http://gerrit.cloudera.org:8080/#/c/16072/7/src/kudu/ranger/ranger_client-test.cc@253
PS7, Line 253:   ASSERT_TRUE(ContainsKey(tables, "default.foobar"));
             :   ASSERT_TRUE(ContainsKey(tables, "barbaz"));
             :   ASSERT_FALSE(ContainsKey(tables, "foo."));
> nit: you can use ContainsKey() from gutil/map-util.h
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9c36b7d84863403d7d538cafc709d2aebd0b109
Gerrit-Change-Number: 16072
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <abukor@apache.org>
Gerrit-Reviewer: Andrew Wong <awong@cloudera.com>
Gerrit-Reviewer: Attila Bukor <abukor@apache.org>
Gerrit-Reviewer: Grant Henke <granthenke@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 30 Jun 2020 14:42:05 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message