kudu-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wong (Code Review)" <ger...@cloudera.org>
Subject [kudu-CR] [master] cache for table locations
Date Tue, 30 Jun 2020 05:26:32 GMT
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15971 )

Change subject: [master] cache for table locations
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15971/2/src/kudu/master/table_locations_cache.cc
File src/kudu/master/table_locations_cache.cc:

http://gerrit.cloudera.org:8080/#/c/15971/2/src/kudu/master/table_locations_cache.cc@145
PS2, Line 145:   DCHECK((ptr_ != nullptr && handle_) ||
> I'll keep it here for debugging as other VLOG() messages.
Oops, seems gerrit didn't highlight properly. You can drop the 'strings::', I meant.



-- 
To view, visit http://gerrit.cloudera.org:8080/15971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d2a4771ddc455d92a1da00db91c555a21151a23
Gerrit-Change-Number: 15971
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <aserbin@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aserbin@cloudera.com>
Gerrit-Reviewer: Andrew Wong <awong@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <bankim@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthenke@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-Comment-Date: Tue, 30 Jun 2020 05:26:32 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message