kudu-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Serbin (Code Review)" <ger...@cloudera.org>
Subject [kudu-CR] [master] cache for table locations
Date Tue, 30 Jun 2020 05:26:23 GMT
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15971 )

Change subject: [master] cache for table locations
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15971/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15971/3//COMMIT_MSG@14
PS3, Line 14: A smaller 12% improvement is observed for GetTableLocations RPC
> Not to be too much of a downer, but is this complexity worth it for 12% end
Yes, it's a good question.  I guess the performance boost will be higher if also optimizing
the part where RPC response is copied from an entry in the cache just to be serialized on
the wire.  In other words, I think that with other improvements in RPC it will get higher.



-- 
To view, visit http://gerrit.cloudera.org:8080/15971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d2a4771ddc455d92a1da00db91c555a21151a23
Gerrit-Change-Number: 15971
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <aserbin@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aserbin@cloudera.com>
Gerrit-Reviewer: Andrew Wong <awong@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <bankim@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthenke@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <todd@apache.org>
Gerrit-Comment-Date: Tue, 30 Jun 2020 05:26:23 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message