From reviews-return-52840-archive-asf-public=cust-asf.ponee.io@kudu.apache.org Tue Jan 7 21:47:14 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B71E7180643 for ; Tue, 7 Jan 2020 22:47:13 +0100 (CET) Received: (qmail 95677 invoked by uid 500); 7 Jan 2020 21:47:13 -0000 Mailing-List: contact reviews-help@kudu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@kudu.apache.org Delivered-To: mailing list reviews@kudu.apache.org Received: (qmail 95665 invoked by uid 99); 7 Jan 2020 21:47:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jan 2020 21:47:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 785561809A4 for ; Tue, 7 Jan 2020 21:47:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.824 X-Spam-Level: X-Spam-Status: No, score=0.824 tagged_above=-999 required=6.31 tests=[FREEMAIL_REPLYTO_END_DIGIT=0.25, HTML_MESSAGE=0.2, KAM_DMARC_STATUS=0.01, RDNS_DYNAMIC=0.363, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id V47Cvb_LMfVz for ; Tue, 7 Jan 2020 21:47:09 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=75.101.130.251; helo=ip-10-146-233-104.ec2.internal; envelope-from=gerrit@cloudera.org; receiver= Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 89699BE74E for ; Tue, 7 Jan 2020 21:47:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id 007Ll790025161; Tue, 7 Jan 2020 21:47:07 GMT Message-Id: <202001072147.007Ll790025161@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 7 Date: Tue, 7 Jan 2020 21:46:58 +0000 From: "Adar Dembo (Code Review)" To: liusheng , reviews@kudu.apache.org CC: Tim Armstrong , Alexey Serbin , huangtianhua223@gmail.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5Bkudu-CR=5D_KUDU-3007=2E_Support_building_Kudu_on_aarch64_platform=0A?= X-Gerrit-Change-Id: I2953519c5d28de17e6b2bb7094abab0c1cd12c97 X-Gerrit-Change-Number: 14964 X-Gerrit-ChangeURL: X-Gerrit-Commit: d94dc2ed70c9ee642ad8d55a5e198c6262b90b29 In-Reply-To: References: X-Gerrit-Comment-Date: Tue, 7 Jan 2020 21:46:58 +0000 Reply-To: adar@cloudera.com, huangtianhua223@gmail.com, bankim@cloudera.com, reviews@kudu.apache.org, tarmstrong@cloudera.com, smcintosh@cloudera.com, aserbin@cloudera.com, ritwik.yadav@gmail.com, chuchao333@gmail.com, liusheng2048@gmail.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="tvX0sJi06PA="; charset=UTF-8 --tvX0sJi06PA= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Adar Dembo has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/14964 ) Change subject: KUDU-3007=2E Support building Kudu on = aarch64 platform =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E Patch Set 7: > I thought to make the building process sucessfully to= be the first step, ane then fix and make the unit tests passed=2E sorry, m= y fault, I wll try to run unitests on aarch64 and share the results here=2E= Here's what I would suggest: 1=2E Work on one large patch that, when appl= ied, you can successfully build Kudu and run all unit tests from end-to-end= =2E 2=2E After that's done, take a step back, look at the patch, and decide= how it should be carved up for review=2E 3=2E Publish N code reviews (wher= e N >=3D 1) that, taken together, add aarch64 support to Kudu=2E Maybe N is= 1 because one giant patch is good enough=2E Maybe it's > 1 because there a= re different logical areas of division=2E That's your call=2E Either way, w= e will have confidence that the changes that were made are correct, and the= focus of the review will be to improve maintainability/readability rather = than to prove correctness=2E -- To view, visit http://gerrit=2Ecloudera= =2Eorg:8080/14964 To unsubscribe, visit http://gerrit=2Ecloudera=2Eorg:8080= /settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: c= omment Gerrit-Change-Id: I2953519c5d28de17e6b2bb7094abab0c1cd12c97 Gerrit-C= hange-Number: 14964 Gerrit-PatchSet: 7 Gerrit-Owner: liusheng Gerrit-Reviewer: Adar Dembo Gerrit-Revi= ewer: Alexey Serbin Gerrit-Reviewer: Anonymous Cow= ard Gerrit-Reviewer: Kudu Jenkins (120) Gerri= t-Reviewer: Tim Armstrong Gerrit-Reviewer: lius= heng Gerrit-Comment-Date: Tue, 07 Jan 2020 21:46= :58 +0000 Gerrit-HasComments: No --tvX0sJi06PA=--