kudu-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adar Dembo (Code Review)" <ger...@cloudera.org>
Subject [kudu-CR] [tablet] Support accurate count of rows
Date Wed, 05 Jun 2019 20:49:02 GMT
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 )

Change subject: [tablet] Support accurate count of rows
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13456/11/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:

http://gerrit.cloudera.org:8080/#/c/13456/11/src/kudu/master/sys_catalog.cc@255
PS11, Line 255:  /*supports_live_row_count=*/ false
> Done
Can you restore this? Like Andrew observed, it's a tiny amount of space, and an exception
for the master tablet draws attention for no good reason.



-- 
To view, visit http://gerrit.cloudera.org:8080/13456
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e6378e289bb85024c29e96c2b153fc417ed6412
Gerrit-Change-Number: 13456
Gerrit-PatchSet: 13
Gerrit-Owner: helifu <hzhelifu@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Andrew Wong <awong@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hzhelifu@corp.netease.com>
Gerrit-Comment-Date: Wed, 05 Jun 2019 20:49:02 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message