From reviews-return-41476-archive-asf-public=cust-asf.ponee.io@kudu.apache.org Mon Feb 11 19:34:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F2E2C180648 for ; Mon, 11 Feb 2019 20:34:11 +0100 (CET) Received: (qmail 72872 invoked by uid 500); 11 Feb 2019 19:34:11 -0000 Mailing-List: contact reviews-help@kudu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@kudu.apache.org Delivered-To: mailing list reviews@kudu.apache.org Received: (qmail 72861 invoked by uid 99); 11 Feb 2019 19:34:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2019 19:34:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1F80DC9CA6 for ; Mon, 11 Feb 2019 19:34:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.613 X-Spam-Level: ** X-Spam-Status: No, score=2.613 tagged_above=-999 required=6.31 tests=[FREEMAIL_REPLYTO_END_DIGIT=0.25, HTML_MESSAGE=2, RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id qIhZeNPKnqhW for ; Mon, 11 Feb 2019 19:34:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A49B95F644 for ; Mon, 11 Feb 2019 19:25:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id x1BJPHiB014652; Mon, 11 Feb 2019 19:25:17 GMT Message-Id: <201902111925.x1BJPHiB014652@ip-10-146-233-104.ec2.internal> X-Gerrit-PatchSet: 7 Date: Mon, 11 Feb 2019 19:25:17 +0000 From: "Mike Percy (Code Review)" To: Will Berkeley , reviews@kudu.apache.org CC: Adar Dembo , Grant Henke , Alexey Serbin X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5Bkudu-CR=5D_KUDU-1868=3A_Part_1=3A_Add_timer-based_RPC_timeouts=0A?= X-Gerrit-Change-Id: I8d823b63ac0a41cc5e42b63a7c19e0ef777e1dea X-Gerrit-Change-Number: 12338 X-Gerrit-ChangeURL: X-Gerrit-Commit: 28f8fc533b2a9ce6c4f8dd31449ab529c6a89ee7 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 11 Feb 2019 19:25:17 +0000 Reply-To: mpercy@apache.org, adar@cloudera.com, bankim@cloudera.com, reviews@kudu.apache.org, granthenke@apache.org, smcintosh@cloudera.com, wdberkeley@gmail.com, aserbin@cloudera.com, davidralves@gmail.com, chuchao333@gmail.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.14.15 Content-Type: multipart/alternative; boundary="AH0gU8biRZA="; charset=UTF-8 --AH0gU8biRZA= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Mike Percy has posted comments on this change=2E ( http://gerrit=2Ecloudera= =2Eorg:8080/12338 ) Change subject: KUDU-1868: Part 1: Add timer-based RPC= timeouts =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E= =2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E=2E = Patch Set 7: (1 comment) http://gerrit=2Ecloudera=2Eorg:8080/#/c/12338/5/= java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient=2Ejav= a File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClien= t=2Ejava: http://gerrit=2Ecloudera=2Eorg:8080/#/c/12338/5/java/kudu-client= /src/main/java/org/apache/kudu/client/AsyncKuduClient=2Ejava@2366 PS5, Line= 2366: if (timer =3D=3D null) { > Should passing a null timer be allowe= d? PreConditions=2EcheckNotNull() seems reasonable here -- To view, vis= it http://gerrit=2Ecloudera=2Eorg:8080/12338 To unsubscribe, visit http://g= errit=2Ecloudera=2Eorg:8080/settings Gerrit-Project: kudu Gerrit-Branch: m= aster Gerrit-MessageType: comment Gerrit-Change-Id: I8d823b63ac0a41cc5e42b6= 3a7c19e0ef777e1dea Gerrit-Change-Number: 12338 Gerrit-PatchSet: 7 Gerrit-Ow= ner: Will Berkeley Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin = Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kud= u Jenkins (120) Gerrit-Reviewer: Mike Percy Gerrit-Re= viewer: Will Berkeley Gerrit-Comment-Date: Mon, 11= Feb 2019 19:25:17 +0000 Gerrit-HasComments: Yes --AH0gU8biRZA=--