kudu-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Percy (Code Review)" <ger...@cloudera.org>
Subject [kudu-CR] KUDU-1868: Part 1: Add timer-based RPC timeouts
Date Mon, 11 Feb 2019 19:25:17 GMT
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12338 )

Change subject: KUDU-1868: Part 1: Add timer-based RPC timeouts
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12338/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:

http://gerrit.cloudera.org:8080/#/c/12338/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2366
PS5, Line 2366:     if (timer == null) {
> Should passing a null timer be allowed?
PreConditions.checkNotNull() seems reasonable here



-- 
To view, visit http://gerrit.cloudera.org:8080/12338
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d823b63ac0a41cc5e42b63a7c19e0ef777e1dea
Gerrit-Change-Number: 12338
Gerrit-PatchSet: 7
Gerrit-Owner: Will Berkeley <wdberkeley@gmail.com>
Gerrit-Reviewer: Adar Dembo <adar@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aserbin@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthenke@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mpercy@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberkeley@gmail.com>
Gerrit-Comment-Date: Mon, 11 Feb 2019 19:25:17 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message