From commits-return-8715-archive-asf-public=cust-asf.ponee.io@kudu.apache.org Tue Mar 31 05:27:09 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6ABC8180686 for ; Tue, 31 Mar 2020 07:27:09 +0200 (CEST) Received: (qmail 27737 invoked by uid 500); 31 Mar 2020 05:27:08 -0000 Mailing-List: contact commits-help@kudu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kudu.apache.org Delivered-To: mailing list commits@kudu.apache.org Received: (qmail 27727 invoked by uid 99); 31 Mar 2020 05:27:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Mar 2020 05:27:08 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 5AC8D819F7; Tue, 31 Mar 2020 05:27:08 +0000 (UTC) Date: Tue, 31 Mar 2020 05:27:08 +0000 To: "commits@kudu.apache.org" Subject: [kudu] branch master updated: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <158563242831.30654.15587484158122046379@gitbox.apache.org> From: adar@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: kudu X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 263c3aa894c087691ef2c4463d46a52a94f12c2b X-Git-Newrev: 03d79bdfda04a07fb7c820b1843ff069cb54e7a1 X-Git-Rev: 03d79bdfda04a07fb7c820b1843ff069cb54e7a1 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. adar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git The following commit(s) were added to refs/heads/master by this push: new 03d79bd [client] Add a note that only FAST_HASH is supported in Bloom filter predicate 03d79bd is described below commit 03d79bdfda04a07fb7c820b1843ff069cb54e7a1 Author: Bankim Bhavsar AuthorDate: Mon Mar 30 17:13:48 2020 -0700 [client] Add a note that only FAST_HASH is supported in Bloom filter predicate Add explicit note that only FAST_HASH is supported in the Bloom filter predicate in client API. There is already validation in BlockBloomFilter for hash algorithm. Test: - Verified the generated HTML output. Change-Id: I5c683fe3be3e9ad2168562c5940e500fffac5316 Reviewed-on: http://gerrit.cloudera.org:8080/15608 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- src/kudu/client/scan_predicate.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/kudu/client/scan_predicate.h b/src/kudu/client/scan_predicate.h index 99b54e4..c6d71d3 100644 --- a/src/kudu/client/scan_predicate.h +++ b/src/kudu/client/scan_predicate.h @@ -144,6 +144,7 @@ class KUDU_EXPORT KuduBloomFilterBuilder { /// @param [in] hash_algorithm /// Hash algorithm used to hash keys before inserting to the Bloom filter. /// If not provided, defaults to FAST_HASH. + /// @note Currently only FAST_HASH is supported. /// @return Reference to the updated object. KuduBloomFilterBuilder& hash_algorithm(HashAlgorithm hash_algorithm);