kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [kudu] 02/02: build: fix linker error in BloomFileTestBase
Date Tue, 17 Mar 2020 17:02:15 GMT
This is an automated email from the ASF dual-hosted git repository.

adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 895e34ec7fa2dc1957f793c04d696a869d932f86
Author: Andrew Wong <awong@cloudera.com>
AuthorDate: Tue Mar 17 02:21:06 2020 -0700

    build: fix linker error in BloomFileTestBase
    
    I saw this when building on macOS:
    
    [241/562] Linking CXX shared library lib/libcfile_test_util.dylib
    FAILED: lib/libcfile_test_util.dylib
    : && /Applications/Xcode.app/Contents/Developer/usr/bin/g++ -msse4.2 -Wall -Wno-sign-compare
-Wno-comment -pthread -fno-strict-aliasing -DBOOST_DATE_TIME_POSIX_TIME_STD_CONFIG  -ggdb
-Qunused-arguments -Wno-ambiguous-member-template -Wdocumentation-depre
    cated-sync -Wno-unknown-warning-option -Wno-address-of-packed-member -std=c++11 -fsized-deallocation
-g -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk
-dynamiclib -Wl,-headerpad_max_install_n
    ames  -o lib/libcfile_test_util.dylib -install_name @rpath/libcfile_test_util.dylib src/kudu/cfile/CMakeFiles/cfile_test_util.dir/bloomfile-test-base.cc.o
 -Wl,-rpath,/Users/awong/Repositories/kudu/build/debug/lib -Wl,-rpath,/Users/awong/Repositories/kud
    u/thirdparty/installed/uninstrumented/lib  lib/libcfile.dylib  lib/libkudu_common.dylib
 lib/libwire_protocol_proto.dylib  lib/libconsensus_metadata_proto.dylib  lib/libkudu_fs.dylib
 lib/libfs_proto.dylib  lib/libkudu_util_compression.dylib  lib/libkudu_util.dylib  ../../thirdparty/installed/uninstrumented/lib/libcrcutil.dylib
 ../../thirdparty/installed/uninstrumented/lib/libgflags.dylib  lib/libhistogram_proto.dylib
 ../../thirdparty/installed/uninstrumented/lib/libev.dylib  lib/li [...]
    r_proto.dylib  lib/libmem_tracker_proto.dylib  lib/libversion_info_proto.dylib  ../../thirdparty/installed/uninstrumented/lib/libyaml-cpp.dylib
 ../../thirdparty/installed/uninstrumented/lib/libtcmalloc.dylib  ../../thirdparty/installed/uninstrumented/li
    b/libz.dylib  ../../thirdparty/installed/uninstrumented/lib/liblz4.a  ../../thirdparty/installed/uninstrumented/lib/libsnappy.dylib
 lib/libgutil.dylib  ../../thirdparty/installed/uninstrumented/lib/libglog.dylib  lib/libcfile_proto.dylib
 lib/libkudu_co
    mmon_proto.dylib  lib/libblock_bloom_filter_proto.dylib  lib/libhash_proto.dylib  lib/libutil_compression_proto.dylib
 lib/libpb_util_proto.dylib  ../../thirdparty/installed/uninstrumented/lib/libprotobuf.dylib
 ../../thirdparty/installed/uninstrumented/
    lib/bitshuffle.a && :
    Undefined symbols for architecture x86_64:
      "kudu::KuduTest::SetUp()", referenced from:
          kudu::cfile::BloomFileTestBase::SetUp() in bloomfile-test-base.cc.o
      "testing::AssertionResult::AssertionResult(testing::AssertionResult const&)", referenced
from:
    ...
    
    Not sure why this wasn't caught in other builds, but the fix is easy
    enough.
    
    Change-Id: I0c4c9506a4afe2476e9adffa5372b7f56bf56199
    Reviewed-on: http://gerrit.cloudera.org:8080/15459
    Reviewed-by: Alexey Serbin <aserbin@cloudera.com>
    Tested-by: Alexey Serbin <aserbin@cloudera.com>
    Reviewed-by: Adar Dembo <adar@cloudera.com>
---
 src/kudu/cfile/CMakeLists.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/kudu/cfile/CMakeLists.txt b/src/kudu/cfile/CMakeLists.txt
index cbffd02..e0c1afb 100644
--- a/src/kudu/cfile/CMakeLists.txt
+++ b/src/kudu/cfile/CMakeLists.txt
@@ -61,7 +61,8 @@ add_library(cfile_test_util
   bloomfile-test-base.cc)
 
 target_link_libraries(cfile_test_util
-  cfile)
+  cfile
+  kudu_test_util)
 
 # Tests
 SET_KUDU_TEST_LINK_LIBS(cfile)


Mime
View raw message