kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [kudu] branch master updated: [client] Add a note that only FAST_HASH is supported in Bloom filter predicate
Date Tue, 31 Mar 2020 05:27:08 GMT
This is an automated email from the ASF dual-hosted git repository.

adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new 03d79bd  [client] Add a note that only FAST_HASH is supported in Bloom filter predicate
03d79bd is described below

commit 03d79bdfda04a07fb7c820b1843ff069cb54e7a1
Author: Bankim Bhavsar <bankim@cloudera.com>
AuthorDate: Mon Mar 30 17:13:48 2020 -0700

    [client] Add a note that only FAST_HASH is supported in Bloom filter predicate
    
    Add explicit note that only FAST_HASH is supported in the Bloom filter
    predicate in client API.
    
    There is already validation in BlockBloomFilter for hash algorithm.
    
    Test:
    - Verified the generated HTML output.
    
    Change-Id: I5c683fe3be3e9ad2168562c5940e500fffac5316
    Reviewed-on: http://gerrit.cloudera.org:8080/15608
    Tested-by: Kudu Jenkins
    Reviewed-by: Adar Dembo <adar@cloudera.com>
---
 src/kudu/client/scan_predicate.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/kudu/client/scan_predicate.h b/src/kudu/client/scan_predicate.h
index 99b54e4..c6d71d3 100644
--- a/src/kudu/client/scan_predicate.h
+++ b/src/kudu/client/scan_predicate.h
@@ -144,6 +144,7 @@ class KUDU_EXPORT KuduBloomFilterBuilder {
   /// @param [in] hash_algorithm
   ///   Hash algorithm used to hash keys before inserting to the Bloom filter.
   ///   If not provided, defaults to FAST_HASH.
+  /// @note Currently only FAST_HASH is supported.
   /// @return Reference to the updated object.
   KuduBloomFilterBuilder& hash_algorithm(HashAlgorithm hash_algorithm);
 


Mime
View raw message