kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aw...@apache.org
Subject [kudu] 01/03: hms: stop trying to get the UUID on success
Date Wed, 18 Sep 2019 23:27:48 GMT
This is an automated email from the ASF dual-hosted git repository.

awong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit fda08769c658a592198e0d9ae35f16dd1fb0ef9d
Author: Andrew Wong <awong@cloudera.com>
AuthorDate: Wed Sep 18 14:22:12 2019 -0700

    hms: stop trying to get the UUID on success
    
    This would result in more traffic to the HMS than necessary.
    
    I tested this manually by adding logging statements and watching a
    long-running test repeatedly fetch from the HMS.
    
    Change-Id: I71156c0756bac8fdb73929a740cc0d9093bc29c2
    Reviewed-on: http://gerrit.cloudera.org:8080/14258
    Reviewed-by: Adar Dembo <adar@cloudera.com>
    Tested-by: Kudu Jenkins
---
 src/kudu/hms/hms_catalog.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/kudu/hms/hms_catalog.cc b/src/kudu/hms/hms_catalog.cc
index 6009e47..ccf22ee 100644
--- a/src/kudu/hms/hms_catalog.cc
+++ b/src/kudu/hms/hms_catalog.cc
@@ -464,7 +464,9 @@ void HmsCatalog::LoopInitializeUuid() {
       VLOG(1) << "Connected to HMS with uuid " << uuid;
       std::lock_guard<simple_spinlock> l(uuid_lock_);
       uuid_ = std::move(uuid);
-    } else if (s.IsNotSupported()) {
+      return;
+    }
+    if (s.IsNotSupported()) {
       VLOG(1) << "Unable to fetch UUID for HMS: " << s.ToString();
       return;
     }


Mime
View raw message