kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject [kudu] 01/02: [tablet_copy_client-test] fix compiler warning
Date Wed, 19 Jun 2019 07:11:24 GMT
This is an automated email from the ASF dual-hosted git repository.

todd pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit d0db4c4cd36c1388e36576742cc7fe8c3adfcb77
Author: Alexey Serbin <aserbin@cloudera.com>
AuthorDate: Tue Jun 18 16:41:23 2019 -0700

    [tablet_copy_client-test] fix compiler warning
    
    Fixed compilation warning in TabletCopyClientTest:
    
      src/kudu/tserver/tablet_copy_client-test.cc:149:16: \
          warning: 'GenerateTestData' overrides a member function but \
          is not marked 'override' [-Winconsistent-missing-override]
        virtual void GenerateTestData() {
                     ^
      src/kudu/tserver/tablet_copy-test-base.h:113:16: \
          note: overridden virtual function is here
        virtual void GenerateTestData() {
                     ^
      1 warning generated.
    
    This patch does not contain any functional modifications.
    
    Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
    Reviewed-on: http://gerrit.cloudera.org:8080/13674
    Tested-by: Alexey Serbin <aserbin@cloudera.com>
    Reviewed-by: Andrew Wong <awong@cloudera.com>
---
 src/kudu/tserver/tablet_copy_client-test.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kudu/tserver/tablet_copy_client-test.cc b/src/kudu/tserver/tablet_copy_client-test.cc
index 5dd9f4e..c24adb6 100644
--- a/src/kudu/tserver/tablet_copy_client-test.cc
+++ b/src/kudu/tserver/tablet_copy_client-test.cc
@@ -146,7 +146,7 @@ class TabletCopyClientTest : public TabletCopyTest {
   Status CompareFileContents(const string& path1, const string& path2);
 
   // Injection of 'supports_live_row_count' modifiers through polymorphic characteristic.
-  virtual void GenerateTestData() {
+  void GenerateTestData() override {
     Random rand(SeedRandom());
     NO_FATALS(tablet_replica_->tablet_metadata()->
         set_supports_live_row_count_for_tests(rand.Next() % 2));


Mime
View raw message