kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [kudu] branch master updated: [www] Show column count on table page
Date Tue, 07 May 2019 07:51:08 GMT
This is an automated email from the ASF dual-hosted git repository.

adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git


The following commit(s) were added to refs/heads/master by this push:
     new fd6155f  [www] Show column count on table page
fd6155f is described below

commit fd6155fc00de48d17a65aafd79fbbad584a4f837
Author: Yingchun Lai <405403881@qq.com>
AuthorDate: Mon May 6 06:22:35 2019 -0400

    [www] Show column count on table page
    
    Table column count is not obvious displayed when it has been altered
    several times, there maybe some holes in column IDs. This patch show
    the current column count of table.
    
    Change-Id: I8c6d471b6ce4f226b58a29e43f3a0c1c916669b2
    Reviewed-on: http://gerrit.cloudera.org:8080/13243
    Reviewed-by: Will Berkeley <wdberkeley@gmail.com>
    Tested-by: Kudu Jenkins
---
 src/kudu/master/master_path_handlers.cc | 1 +
 www/table.mustache                      | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/kudu/master/master_path_handlers.cc b/src/kudu/master/master_path_handlers.cc
index 601557d..a8d81f7 100644
--- a/src/kudu/master/master_path_handlers.cc
+++ b/src/kudu/master/master_path_handlers.cc
@@ -328,6 +328,7 @@ void MasterPathHandlers::HandleTablePage(const Webserver::WebRequest&
req,
       (*output)["error"] = Substitute("Unable to decode schema: $0", s.ToString());
       return;
     }
+    (*output)["column_count"] = schema.num_columns();
     s = PartitionSchema::FromPB(l.data().pb.partition_schema(), schema, &partition_schema);
     if (!s.ok()) {
       (*output)["error"] =
diff --git a/www/table.mustache b/www/table.mustache
index 6a960d9..fc82a80 100644
--- a/www/table.mustache
+++ b/www/table.mustache
@@ -31,6 +31,7 @@ under the License.
     <tbody>
     <tr><td>Version:</td><td>{{version}}</td></tr>
     <tr><td>State:</td><td>{{state}} {{#state_msg}}({{.}}){{/state_msg}}</td></tr>
+    <tr><td>Column Count:</td><td>{{column_count}}</td></tr>
     </tbody>
   </table>
 


Mime
View raw message